app-project: add /projects to useProjectNavigation external links (#6342

) * add /projects to useProjectNavigation external links * Fix tests for DropdownNav, Nav, and ProjectHeader. --------- Co-authored-by: kieftrav <[email protected]>
zooniverse · Sep 26, 2024 · 79c80fa · 79c80fa
1 parent a240e57
commit 79c80fa
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 9 deletions.
diff --git a/packages/app-project/src/components/ProjectHeader/ProjectHeader.spec.js b/packages/app-project/src/components/ProjectHeader/ProjectHeader.spec.js
@@ -82,7 +82,7 @@ describe('Component > ProjectHeader', function () {
       expect(navLinks.length).to.be.above(0)
       expect(navLinks[0].href).to.equal('https://localhost/zooniverse/snapshot-serengeti/about/research')
       expect(navLinks[navLinks.length - 1].href).to.equal(
-        'https://localhost/zooniverse/snapshot-serengeti/collections'
+        'https://localhost/projects/zooniverse/snapshot-serengeti/collections'
       )
     })
   })
@@ -95,7 +95,7 @@ describe('Component > ProjectHeader', function () {
 
       expect(navLinks.length).to.be.above(0)
       expect(navLinks[0].href).to.equal('https://localhost/zooniverse/snapshot-serengeti/about/research')
-      expect(navLinks[navLinks.length - 1].href).to.equal('https://localhost/zooniverse/snapshot-serengeti/recents')
+      expect(navLinks[navLinks.length - 1].href).to.equal('https://localhost/projects/zooniverse/snapshot-serengeti/recents')
     })
   })
 

diff --git a/packages/app-project/src/components/ProjectHeader/components/DropdownNav/DropdownNav.spec.js b/packages/app-project/src/components/ProjectHeader/components/DropdownNav/DropdownNav.spec.js
@@ -47,7 +47,7 @@ describe('Component > ProjectHeader > Dropdown Nav', function () {
       expect(navLinks.length).to.be.above(0)
       expect(navLinks[0].href).to.equal('https://localhost/zooniverse/snapshot-serengeti/about/research')
       expect(navLinks[navLinks.length - 1].href).to.equal(
-        'https://localhost/zooniverse/snapshot-serengeti/collections'
+        'https://localhost/projects/zooniverse/snapshot-serengeti/collections'
       )
     })
   })
@@ -75,7 +75,7 @@ describe('Component > ProjectHeader > Dropdown Nav', function () {
       const navLinks = within(navMenu).getAllByRole('link')
       expect(navLinks.length).to.be.above(0)
       expect(navLinks[0].href).to.equal('https://localhost/zooniverse/snapshot-serengeti/about/research')
-      expect(navLinks[navLinks.length - 1].href).to.equal('https://localhost/zooniverse/snapshot-serengeti/recents')
+      expect(navLinks[navLinks.length - 1].href).to.equal('https://localhost/projects/zooniverse/snapshot-serengeti/recents')
     })
   })
 

diff --git a/packages/app-project/src/components/ProjectHeader/components/Nav/Nav.spec.js b/packages/app-project/src/components/ProjectHeader/components/Nav/Nav.spec.js
@@ -39,7 +39,7 @@ describe('Component > ProjectHeader > Nav', function () {
       expect(navLinks.length).to.be.above(0)
       expect(navLinks[0].href).to.equal('https://localhost/zooniverse/snapshot-serengeti/about/research')
       expect(navLinks[navLinks.length - 1].href).to.equal(
-        'https://localhost/zooniverse/snapshot-serengeti/collections'
+        'https://localhost/projects/zooniverse/snapshot-serengeti/collections'
       )
     })
   })
@@ -60,7 +60,7 @@ describe('Component > ProjectHeader > Nav', function () {
       const navLinks = within(navMenu).getAllByRole('link')
       expect(navLinks.length).to.be.above(0)
       expect(navLinks[0].href).to.equal('https://localhost/zooniverse/snapshot-serengeti/about/research')
-      expect(navLinks[navLinks.length - 1].href).to.equal('https://localhost/zooniverse/snapshot-serengeti/recents')
+      expect(navLinks[navLinks.length - 1].href).to.equal('https://localhost/projects/zooniverse/snapshot-serengeti/recents')
     })
   })
 

diff --git a/packages/app-project/src/components/ProjectHeader/hooks/useProjectNavigation.js b/packages/app-project/src/components/ProjectHeader/hooks/useProjectNavigation.js
@@ -16,20 +16,20 @@ export default function useProjectNavigation(adminMode) {
       text: t('ProjectHeader.classify')
     },
     {
-      href: `/${slug}/talk`,
+      href: `/projects/${slug}/talk`,
       text: t('ProjectHeader.talk'),
       externalLink: true // code is in PFE
     },
     {
-      href: `/${slug}/collections`,
+      href: `/projects/${slug}/collections`,
       text: t('ProjectHeader.collect'),
       externalLink: true // code is in PFE
     }
   ]
 
   if (isLoggedIn) {
     links.push({
-      href: `/${slug}/recents`,
+      href: `/projects/${slug}/recents`,
       text: t('ProjectHeader.recents'),
       externalLink: true // code is in PFE
     })