-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WildCam Lab Classrooms - 2018 Rebuild - part 1 #122
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
This PR is a massive overhaul of the WildCam Lab Classrooms and overrides previous work done in #107 and #114 . Requirements for WildCam-type classrooms and Astro-type classrooms have diverged in such a way that it now makes more sense to separate out WildCam-type components from the "standard" (i.e. Astro) classrooms.
Major Updates:
/programs
folder./modules
folder.module
should be fairly standalone - its/ducks
,/containers
,components
should be easily separated from other modules' ducks/containers/components - and should be easy to plug into future WildCam-type Programs.MAP_STATE()
pattern allows for quickly mapping a store's data values to a React's props.Actions.wcc_teachers_fetchClassrooms
is distinct fromActions.getClassrooms
and (hopefully) signals to devs that anywcc_...
code is related to the WildCam Classrooms module.MAP_STATE()
lets us add prefixes to the mapped data keys in case we want to avoid collisions in a React component that accesses multiple Redux stores with similar keys. (e.g. "classrooms.status" and "assignments.status") Honestly, I don't see it being used much in this app, but I like the pattern enough to keep it in for future refrence.WILDCAMCLASSROOMS_DATA_STATUS
can be a mouthful... I might rename this toWCC_DATA_STATUS
in the future if that makes sense to people.Clarification:
/modules
and/programs
is to separate the general from the specific. e.g. WildCam Darien and WildCam Gorongosa may both be programs, and each program will have their own specific configurations. Those configurations then plug into the general WildCamClassrooms and WildCamMaps components./programs
and not worry about the actual logic of how the components work (in/modules
)SAFETY:
NOT YET BUILT:
Status
Merging, part 2 coming soon.