Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Stats to Navbar and Hide Landing Page Stats #221

Merged
merged 1 commit into from
Jan 19, 2018
Merged

Conversation

wgranger
Copy link
Contributor

This is to be merged once we are finished with beta and ready for the full launch. This PR currently hides the incorrect project stats in lieu of a stats link on the navbar until we choose which variant (collaborative or individual) we want to stick with.

A further description is in #220

@wgranger wgranger changed the title [Do Not Merge] Add Stats to Navbar and Hide Stats [Do Not Merge] Add Stats to Navbar and Hide Landing Page Stats Jan 15, 2018
@wgranger wgranger changed the title [Do Not Merge] Add Stats to Navbar and Hide Landing Page Stats Add Stats to Navbar and Hide Landing Page Stats Jan 16, 2018
@wgranger wgranger mentioned this pull request Jan 16, 2018
8 tasks
Copy link
Member

@shaunanoordin shaunanoordin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review

Simple content update:

  • the project navbar no longer links to Feedback (which was only used for the Beta)
  • the project navbar now has a link to the PFE Stats page for the project
  • the home page's Stats section? Gone.

Status

LGTM

@shaunanoordin shaunanoordin merged commit f315442 into master Jan 19, 2018
@wgranger wgranger deleted the stats-navbar branch January 19, 2018 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants