Added functionality to question extract to process survey tasks (for user skill calculation) #673
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 13, 2023 15:49
…void duplicate entries
CKrawczyk
approved these changes
Jan 19, 2023
Comment on lines
119
to
123
| single_pluck_classification, | ||
| single_pluck_expected, | ||
| "Test pluck field functionality with a question extractor", | ||
| kwargs={'pluck': single_pluck_keys}, | ||
| test_name='TestSinglePluck') |
There was a problem hiding this comment.
Don't add the extra spaces here (this is one part of PEP8's style I don't agree with. I would rather the style be:
TestSinglePluck = ExtractorTest(
extractors.question_extractor,
single_pluck_classification,
...
)I think it looks cleaner than having a large blank space on each line.
There was a problem hiding this comment.
Fixed! Ready for merging whenever you have the chance!
|
I will merge on Monday to avoid a Friday deploy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current survey extractor creates a list of dictionaries, which breaks the current user skill calculation (see #607). As a workaround, we have updated the question extractor to process survey task-like inputs. This is done using a simple switch where if the input is a dictionary (as it is for survey tasks), we parse the dictionary keys to get the output in a compatible fashion to the traditional question task output. We have added a new question extractor test to cover this change.
We also made minor fixes to the user skill calculation and make the k-class processing be case insensitive.