Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST ONLY Talk rails 5.2 testing with canary header #7208

Closed
wants to merge 2 commits into from

Conversation

yuenmichelle1
Copy link
Contributor

@yuenmichelle1 yuenmichelle1 commented Oct 31, 2024

Staging branch URL: https://pr-7208.pfe-preview.zooniverse.org

Fixes # .

Describe your changes.

Required Manual Testing

  • Does the non-logged in home page render correctly?
  • Does the logged in home page render correctly?
  • Does the projects page render correctly?
  • Can you load project home pages?
  • Can you load the classification page?
  • Can you submit a classification?
  • Does talk load correctly?
  • Can you post a talk comment?

Review Checklist

  • Does it work in all major browsers: Firefox, Chrome, Edge, Safari?
  • Does it work on mobile?
  • Can you npm ci and app works as expected?
  • If the component is in coffeescript, is it converted to ES6? Is it free of eslint errors? Is the conversion its own commit?
  • Are the tests passing locally and on GitHub Actions?

Optional

@coveralls
Copy link

coveralls commented Oct 31, 2024

Coverage Status

coverage: 56.684% (+0.004%) from 56.68%
when pulling 9ef4c02 on talk-rails-5.2-canary-test
into 6baeeaf on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants