Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump style-loader from 3.3.3 to 4.0.0 #7154

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 20, 2024

Bumps style-loader from 3.3.3 to 4.0.0.

Release notes

Sourced from style-loader's releases.

v4.0.0

4.0.0 (2024-04-08)

⚠ BREAKING CHANGES

  • minimum supported webpack version is 5.27.0
  • minimum support Node.js version is 18.12.0
  • the insert option can only be a selector or the path to the module

Migration:

Before:

webpack.config.js

module.exports = {
  module: {
    rules: [
      {
        test: /\.css$/i,
        use: [
          {
            loader: "style-loader",
            options: {
              injectType: "styleTag",
              styleTagTransform: function (css, style) {
                // Do something ...
                style.innerHTML = `${css}.modify{}\n`;
            document.head.appendChild(style);
          },
        },
      },
      "css-loader",
    ],
  },
],

},
};

After:

insert-function.js

function insert(css, style) {
  var parent = options.target || document.head;
</tr></table> 

... (truncated)

Changelog

Sourced from style-loader's changelog.

4.0.0 (2024-04-08)

⚠ BREAKING CHANGES

  • minimum supported webpack version is 5.27.0
  • minimum support Node.js version is 18.12.0
  • the insert option can only be a selector or the path to the module

Migration:

Before:

webpack.config.js

module.exports = {
  module: {
    rules: [
      {
        test: /\.css$/i,
        use: [
          {
            loader: "style-loader",
            options: {
              injectType: "styleTag",
              styleTagTransform: function (css, style) {
                // Do something ...
                style.innerHTML = `${css}.modify{}\n`;
            document.head.appendChild(style);
          },
        },
      },
      &quot;css-loader&quot;,
    ],
  },
],

},
};

After:

insert-function.js

function insert(css, style) {
  var parent = options.target || document.head;
</tr></table>

... (truncated)

Commits
  • 091d37d chore(release): 4.0.0
  • abc0b5f docs: improve more
  • 565362c docs: update
  • 7122cde refactor!: the insert option can only be a selector or the path to the mo...
  • 11b8639 refactor!: the styleTagTransform option can only be the path to the module
  • 7ec1120 test: fix
  • 977bb71 refactor!: minimum supported webpack version is 5.27.0
  • a70555a test: update
  • dc6e368 refactor!: minimum support Node.js version is 18.12.0
  • b7cdc6c chore: update codecov-action to v4 (#623)
  • Additional commits viewable in compare view

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies javascript Pull requests that update Javascript code labels Aug 20, 2024
@coveralls
Copy link

coveralls commented Aug 20, 2024

Coverage Status

coverage: 56.659% (-0.004%) from 56.663%
when pulling c6a3051 on dependabot/npm_and_yarn/style-loader-4.0.0
into f492f5f on master.

@shaunanoordin
Copy link
Member

@dependabot rebae

@shaunanoordin
Copy link
Member

@dependabot rebase

Bumps [style-loader](https://github.com/webpack-contrib/style-loader) from 3.3.3 to 4.0.0.
- [Release notes](https://github.com/webpack-contrib/style-loader/releases)
- [Changelog](https://github.com/webpack-contrib/style-loader/blob/master/CHANGELOG.md)
- [Commits](webpack-contrib/style-loader@v3.3.3...v4.0.0)

---
updated-dependencies:
- dependency-name: style-loader
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/style-loader-4.0.0 branch from 65d5232 to c6a3051 Compare November 1, 2024 13:52
@shaunanoordin
Copy link
Member

Ignoring that I just asked Dependabot to once again be my bae (rebae) instead of rebase, this PR is going to be "fun" to review.

This is a major bump, with the following notes:

  • now requires webpack 5.27.0
  • now requires Node.js 18.12.0
  • The insert and styleTagTransform options have breaking changes - but fortunately, PFE's webpack configs don't use these options.

Manual testing commences.

Copy link
Member

@shaunanoordin shaunanoordin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. PFE looks good on local.

@shaunanoordin shaunanoordin merged commit bf8ffe0 into master Nov 1, 2024
5 checks passed
@shaunanoordin shaunanoordin deleted the dependabot/npm_and_yarn/style-loader-4.0.0 branch November 1, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants