Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert FEM migration for Walleye project #7086

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Revert FEM migration for Walleye project #7086

merged 1 commit into from
Apr 26, 2024

Conversation

zwolf
Copy link
Member

@zwolf zwolf commented Apr 26, 2024

Newly migrated project Where's Walleye is having issues with FEM. This migrates the project back but will require a Friday deploy to get out quickly.

static PR: zooniverse/static#350

Required Manual Testing

  • Does the non-logged in home page render correctly?
  • Does the logged in home page render correctly?
  • Does the projects page render correctly?
  • Can you load project home pages?
  • Can you load the classification page?
  • Can you submit a classification?
  • Does talk load correctly?
  • Can you post a talk comment?

Review Checklist

  • Does it work in all major browsers: Firefox, Chrome, Edge, Safari?
  • Does it work on mobile?
  • Can you npm ci and app works as expected?
  • If the component is in coffeescript, is it converted to ES6? Is it free of eslint errors? Is the conversion its own commit?
  • Are the tests passing locally and on GitHub Actions?

Optional

@coveralls
Copy link

Coverage Status

coverage: 56.977% (+0.02%) from 56.955%
when pulling b7833e8 on revert-walleye
into 5d5242a on master.

@mcbouslog mcbouslog merged commit 7fa218a into master Apr 26, 2024
5 checks passed
@mcbouslog mcbouslog deleted the revert-walleye branch April 26, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants