-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Email Settings: add "valid email" and "verified email" status #7083
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some comments on how to make this work for screen reader users.
<div> | ||
{(isEmailValid) | ||
? <div> | ||
<i className='fa fa-check-circle' style={{ color: '#51db72' }} /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This icon will be missed by a screen reader. As an aside, icon fonts aren’t really used in web development any more, because they can cause accessibility problems.
21cfd06
to
f65ba13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Please remove the new translations from all dictionaries other than en.js, and good to consider the accessibility comments from Jim.
On this PR branch I'm able to sign-in to my account and see that my email is valid and verified. If I create a new account, the email correctly shows it's unverified until I follow the confirm-email email. I can also edit the email validity of my account by removing the "@". I'll note that if my account has an invalid email, and I edit it to a valid email, a page refresh is not required for the settings indicator to change to "valid". However, if I change from a valid email to an invalid email, a page refresh is required to see the "invalid" indicator. Not a blocking behavior, but worth noting the quirk.
f65ba13
to
e568565
Compare
Thank you! 👍 I'll address the following feedback before I merge:
The "request confirmation email" functionality will appear in a follow up PR. |
e568565
to
583c957
Compare
PR Overview
Staging branch URL: https://pr-7083.pfe-preview.zooniverse.org
Towards #7032
This PR adds "🟢 valid / 🔴 invalid email" and "🟢 verified / 🔴 unverified email" indicators to the Email Settings page (under User -> Settings -> Email)
user.valid_email
anduser.confirmed_at
values of the User resource.Status
Ready for review.
Next steps: the "request confirmation email" functionality requires either
For this PR, the "request confirmation email" has been disabled. (I got halfway through option 1 but ran into some bugs due to a malformed request, and option 3 hit a small snag when I realised I need to check the env to get the correct URL.)