Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FEM redirect for Civil War Bluejackets #7058

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Conversation

zwolf
Copy link
Member

@zwolf zwolf commented Mar 14, 2024

Add FEM redirects for Civil War: Bluejackets (Project 21982)

Staging branch URL: https://pr-7058.pfe-preview.zooniverse.org/
Staging URL for Project: https://pr-7058.pfe-preview.zooniverse.org/projects/bluejackets/civil-war-bluejackets
Target Link: https://www.zooniverse.org/projects/bluejackets/civil-war-bluejackets
Project Lab Link: https://www.zooniverse.org/lab/18285

Static PR: zooniverse/static#342

Required Manual Testing

  • Does the non-logged in home page render correctly?
  • Does the logged in home page render correctly?
  • Does the projects page render correctly?
  • Can you load project home pages?
  • Can you load the classification page?
  • Can you submit a classification?
  • Does talk load correctly?
  • Can you post a talk comment?

Review Checklist

  • Does it work in all major browsers: Firefox, Chrome, Edge, Safari?
  • Does it work on mobile?
  • Can you npm ci and app works as expected?
  • If the component is in coffeescript, is it converted to ES6? Is it free of eslint errors? Is the conversion its own commit?
  • Are the tests passing locally and on GitHub Actions?

Optional

@coveralls
Copy link

coveralls commented Mar 14, 2024

Coverage Status

coverage: 56.959%. remained the same
when pulling d06af8a on fem-redirect-bluejackets
into 587266f on master.

@zwolf zwolf merged commit f1701c0 into master Mar 21, 2024
5 checks passed
@zwolf zwolf deleted the fem-redirect-bluejackets branch March 21, 2024 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants