Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix notification-section tests #6972

Merged
merged 1 commit into from
Dec 4, 2023
Merged

Conversation

mcbouslog
Copy link
Contributor

@mcbouslog mcbouslog commented Dec 1, 2023

Staging branch URL: https://pr-6972.pfe-preview.zooniverse.org

Fixes issue noted with recent PRs CI testing on node v20.10.0. The NotificationSection tests were providing a non-iterable value for an item that the component needs to be iterable.

This issue reminded me notifications would benefit from a refactor like #6815 or similar.

Describe your changes.

  • refactor tests with props and state values such that component doesn't error when shallow rendered for tests

Required Manual Testing

  • Does the non-logged in home page render correctly?
  • Does the logged in home page render correctly?
  • Does the projects page render correctly?
  • Can you load project home pages?
  • Can you load the classification page?
  • Can you submit a classification?
  • Does talk load correctly?
  • Can you post a talk comment?

Review Checklist

  • Does it work in all major browsers: Firefox, Chrome, Edge, Safari?
  • Does it work on mobile?
  • Can you npm ci and app works as expected?
  • If the component is in coffeescript, is it converted to ES6? Is it free of eslint errors? Is the conversion its own commit?
  • Are the tests passing locally and on GitHub Actions?

Optional

@mcbouslog mcbouslog requested a review from a team December 1, 2023 20:03
@coveralls
Copy link

Coverage Status

coverage: 56.999% (-0.06%) from 57.057%
when pulling 63057e1 on fix-notification-section-tests
into 304aa9a on master.

@mcbouslog mcbouslog changed the title Refactor notification-section tests Fix notification-section tests Dec 1, 2023
@yuenmichelle1 yuenmichelle1 mentioned this pull request Dec 4, 2023
18 tasks
Copy link
Contributor

@goplayoutside3 goplayoutside3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mcbouslog mcbouslog merged commit 2ff2f55 into master Dec 4, 2023
5 checks passed
@mcbouslog mcbouslog deleted the fix-notification-section-tests branch December 4, 2023 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants