Pages Editor: organise Steps and Tasks in UI #6898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Small visual point. The yellow colour still makes the task keys look like they should be clickable. |
Wait, nuts! That's an important point - Sean updated the Task Key visual design and I completely forgot I needed to update that, argh! Thanks for pointing that out, taking care of it now. Screenshot: Sean's intended design, post-6868. 
|
shaunanoordin
force-pushed
the
pages-editor-pt7
branch
from
61170ea to
1b0071b
Compare
PR Update
|
shaunanoordin
force-pushed
the
pages-editor-pt7
branch
from
d6df041 to
161a180
Compare
shaunanoordin
force-pushed
the
pages-editor-pt7
branch
from
161a180 to
ed49700
Compare
eatyourgreens
approved these changes
Nov 3, 2023
Comment on lines
+1
to
+5
| /* eslint-disable no-console */ | ||
| /* eslint-disable react/react-in-jsx-scope */ | ||
| /* eslint-disable react/require-default-props */ | ||
| /* eslint-disable radix */ | ||
| /* eslint-disable react/jsx-boolean-value */ |
There was a problem hiding this comment.
You could add these to the ESLint config, rather than add them to every file.
| </select> | ||
| </div> | ||
| <ul className="steps-list" aria-label="Pages/Steps"> | ||
| {/* WARNING: this should be workflow.steps */} |
There was a problem hiding this comment.
It is workflow.steps now.
shaunanoordin
force-pushed
the
pages-editor-pt7
branch
from
ed49700 to
2ec3b0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Overview
Part of: Pages Editor MVP project and FEM Lab super-project
Follow #6888
Staging branch URL: https://pr-6898.pfe-preview.zooniverse.org/lab/1982/workflows/editor/3711?env=staging
This PR updates the Tasks Page's UI so that it lists the workflow's Tasks, organised in Steps.
Screenshot: 3-page workflow with 1, 1, and 2 . Behind the scenes, the Steps are labelled
['P0', 'P1', 'S2']- this is due to the first 2 Question tasks being added via Pages Editor, and the last Transcription Task added via project builder classic.Note: this is a good sign that mixed-editor usage isn't causing any problems. (Yet.)
Testing
Testing has been done with macOS + Chrome. This is primarily a UI update, so ensure that the actual webpage matches the intended design.
Status
Ready for review