-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an organisation Talk page #5415
base: master
Are you sure you want to change the base?
Conversation
fb3d56c
to
f4a24b3
Compare
f4a24b3
to
7dad491
Compare
Drawing tools in the rewrite is top priority right now, but we can definitely circle back to this when we can. Org improvements are slotted for fall and we can use this to figure out what is needed to get this actually working. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
1f0dc44
to
91857dd
Compare
Good news: setting up a new Talk section and adding boards works for organisations without any changes to existing code. Bad news: Links in the Talk template code are hard-coded to use |
1b4423e
to
fec5057
Compare
Adding boards, discussions and comments should now be working for my test organisation at https://pr-5415.pfe-preview.zooniverse.org/organizations/eatyourgreens/my-first-organisation/talk?env=production Open questions:
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
There’s a working organisation Talk at https://pr-5415.pfe-preview.zooniverse.org/organizations/eatyourgreens/my-first-organisation/talk?env=production |
Add a Talk section called org-{organisation.id}. Passes the organisation down to Talk components as the project prop.
Derive a base URL for links from the type of project resource.
Update the projectSection helper to include organisations. Update main Talk page and recent comments to use projectSection.
Add base URLs to comment links, based on the type of project resource.
84995c2
to
674f584
Compare
A simple experiment in adding a Talk page for organisation. It looks for a Talk section called
org-{organisation.id}
. Overrides the project prop by passing downproject={organization}
and generalises link URLs based on the resource type (organisations
orprojects
.)This is mostly an experiment to see what breaks when you try to load Talk for an organisation ie. where in the code do we assume that Talk is only for projects.
Staging branch URL: https://pr-5415.pfe-preview.zooniverse.org
Required Manual Testing
Review Checklist
rm -rf node_modules/ && npm install
and app works as expected?Optional
ChangeListener
orPromiseRenderer
components with code that updates component state?