Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an organisation Talk page #5415

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

eatyourgreens
Copy link
Contributor

@eatyourgreens eatyourgreens commented Jun 20, 2019

A simple experiment in adding a Talk page for organisation. It looks for a Talk section called org-{organisation.id}. Overrides the project prop by passing down project={organization} and generalises link URLs based on the resource type (organisations or projects.)

This is mostly an experiment to see what breaks when you try to load Talk for an organisation ie. where in the code do we assume that Talk is only for projects.

Staging branch URL: https://pr-5415.pfe-preview.zooniverse.org

Required Manual Testing

  • Does the non-logged in home page render correctly?
  • Does the logged in home page render correctly?
  • Does the projects page render correctly?
  • Can you load project home pages?
  • Can you load the classification page?
  • Can you submit a classification?
  • Does talk load correctly?
  • Can you post a talk comment?

Review Checklist

  • Does it work in all major browsers: Firefox, Chrome, Edge, Safari?
  • Does it work on mobile?
  • Can you rm -rf node_modules/ && npm install and app works as expected?
  • If the component is in coffeescript, is it converted to ES6? Is it free of eslint errors? Is the conversion its own commit?
  • Are the tests passing locally and on Travis?

Optional

@coveralls
Copy link

coveralls commented Jun 20, 2019

Coverage Status

coverage: 57.232% (+0.008%) from 57.224% when pulling fc24526 on organisation-talk into d82691b on master.

@srallen
Copy link
Contributor

srallen commented Jun 20, 2019

Drawing tools in the rewrite is top priority right now, but we can definitely circle back to this when we can. Org improvements are slotted for fall and we can use this to figure out what is needed to get this actually working.

@eatyourgreens eatyourgreens removed the request for review from mcbouslog September 24, 2019 14:40
@stale
Copy link

stale bot commented Jan 22, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jan 22, 2020
@mcbouslog mcbouslog removed the stale label Jan 22, 2020
@eatyourgreens eatyourgreens force-pushed the organisation-talk branch 2 times, most recently from 1f0dc44 to 91857dd Compare March 23, 2020 10:34
@eatyourgreens
Copy link
Contributor Author

eatyourgreens commented Mar 23, 2020

Good news: setting up a new Talk section and adding boards works for organisations without any changes to existing code.

Bad news: Links in the Talk template code are hard-coded to use /projects or fallback to Zoo Talk if no project is passed down in props.

https://pr-5415.pfe-preview.zooniverse.org/organizations/eatyourgreens/my-first-organisation/talk?env=production

Screenshot of a an organisation Talk page with one board set up.

https://pr-5415.pfe-preview.zooniverse.org/organizations/eatyourgreens/my-first-organisation/talk/3161?env=production

Screenshot of an organisation Talk board.

https://pr-5415.pfe-preview.zooniverse.org/organizations/eatyourgreens/my-first-organisation/talk/3161/1292307?env=production

Screenshot of an organisation Talk board with a single comment and a reply form.

@eatyourgreens eatyourgreens force-pushed the organisation-talk branch 5 times, most recently from 1b4423e to fec5057 Compare March 23, 2020 14:18
@eatyourgreens
Copy link
Contributor Author

Adding boards, discussions and comments should now be working for my test organisation at https://pr-5415.pfe-preview.zooniverse.org/organizations/eatyourgreens/my-first-organisation/talk?env=production

Open questions:

  • what to name the project prop now that it can pass down an organisation or a project?
  • use organization-1234 as the convention for organisation Talk sections?

@stale
Copy link

stale bot commented Jul 25, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Jul 25, 2020
@stale
Copy link

stale bot commented Dec 19, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Dec 19, 2020
@eatyourgreens
Copy link
Contributor Author

Add a Talk section called org-{organisation.id}. Passes the organisation down to Talk components as the project prop.
Derive a base URL for links from the type of project resource.
Update the projectSection helper to include organisations. Update main Talk page and recent comments to use projectSection.
Add base URLs to comment links, based on the type of project resource.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants