Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LDNS submodule to v1.8.4 #202

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

MichaelTimbert
Copy link
Contributor

Purpose

Update LDNS submodule to 1.8.4

Context

Close #194

@MichaelTimbert MichaelTimbert added the S-PRforIssue Status: There is a PR that is meant to resolve the issue label Aug 21, 2024
@MichaelTimbert MichaelTimbert added this to the v2024.2 milestone Aug 21, 2024
@MichaelTimbert MichaelTimbert self-assigned this Aug 21, 2024
@tgreenx tgreenx changed the base branch from master to develop August 21, 2024 14:53
@tgreenx tgreenx added V-Patch Versioning: The change gives an update of patch in version. and removed S-PRforIssue Status: There is a PR that is meant to resolve the issue labels Aug 21, 2024
@matsduf
Copy link
Contributor

matsduf commented Aug 21, 2024

Travis does not like this for some reason.

@marc-vanderwal
Copy link
Contributor

That’s because running autoreconf -fi on LDNS’s source tree errors out with:

configure.ac:3: error: Autoconf version 2.71 or higher is required

The OS used for CI is Ubuntu 20.04 LTS (focal), which provides autoconf version 2.69. Too bad :(

@marc-vanderwal
Copy link
Contributor

It won’t be easy to fix. I don’t think Ubuntu 20.04 is likely to provide a newer autoconf in its package repositories. On the other hand, autoconf 2.71 fixes lots of bugs but has backwards compatibility issues, so I don’t know if we can reasonably expect ldns to lower its requirement of autoconf.

For CI, the easiest fix is to test with a later version of Ubuntu. Regardless of how we proceed to fix CI, we’ll have to document that Ubuntu 20.04 users must install ldns separately, then install Zonemaster::LDNS with --no-internal-ldns.

@matsduf
Copy link
Contributor

matsduf commented Aug 22, 2024

For CI, the easiest fix is to test with a later version of Ubuntu. Regardless of how we proceed to fix CI, we’ll have to document that Ubuntu 20.04 users must install ldns separately, then install Zonemaster::LDNS with --no-internal-ldns.

But only if we decide to upgrade LDNS to 1.8.4, right? As far as I can see, only LDNS 1.7.0 is available for Ubuntu 20.04. That could mean that we have to drop Ubuntu 20.04 already for v2024.2 instead of for v2025.1. Maybe that is OK.

@marc-vanderwal
Copy link
Contributor

Alternatively, we could wait until we are working on v2025.1 before merging.

@matsduf
Copy link
Contributor

matsduf commented Sep 3, 2024

Yes, I support waiting until v2025.1 or even v2025.2.

@tgreenx tgreenx modified the milestones: v2024.2, v2025.1 Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V-Patch Versioning: The change gives an update of patch in version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Zonemaster-LDNS to LDNS v1.8.4
4 participants