Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposition to set up github action #201

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

MichaelTimbert
Copy link
Contributor

Purpose

Propose an CI solution using github action.
If accepted this can close #195 and #119, since it is no longer necessary to test the MANIFEST in the test suite.

How to test this PR

Github action must be run when a push is made on [develop, master, releases] or when a pull request is requested.
This must run the test suite and fail if an error is reported.
Same if 'make distcheck' report missing files.

@matsduf
Copy link
Contributor

matsduf commented Aug 21, 2024

If we get the same function as #119 or will the CI halt if MANIFEST,MANIFEST.SKIP is not updated? If so I think it is better to run it as a t file to get as much information as possible.

I am for switching to Github action. We already run that for Zonemaster-Engine. Is this solution the same or are there some differences? I think it should be as equal as possible.

@MichaelTimbert
Copy link
Contributor Author

As discussed in #195 I can create another job in github action to check MANIFEST.*. This will improve the readability.

@matsduf
Copy link
Contributor

matsduf commented Aug 22, 2024

Can you explain what the purpose is of having the MANIFEST checks in both ci.yml and manifest.yml?

Is this solution the same as the one that we already run in Zonemaster-Engine?

@MichaelTimbert
Copy link
Contributor Author

Can you explain what the purpose is of having the MANIFEST checks in both ci.yml and manifest.yml?

None, it's one or the other not both.
Actually Zonemaster-Engine use the t/manifest.t method. For the moment, I will remove the verification of the manifest in github-action and keep it with t/manifest.t so that it is the same as in zonemaster-Engine.

@matsduf matsduf added the V-Patch Versioning: The change gives an update of patch in version. label Oct 11, 2024
@matsduf
Copy link
Contributor

matsduf commented Oct 11, 2024

@MichaelTimbert, as far as I can see this can be merged.

@MichaelTimbert MichaelTimbert merged commit 2e8d299 into zonemaster:develop Oct 15, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
V-Patch Versioning: The change gives an update of patch in version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants