-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposition to set up github action #201
Proposition to set up github action #201
Conversation
If we get the same function as #119 or will the CI halt if I am for switching to Github action. We already run that for Zonemaster-Engine. Is this solution the same or are there some differences? I think it should be as equal as possible. |
As discussed in #195 I can create another job in github action to check |
Can you explain what the purpose is of having the MANIFEST checks in both Is this solution the same as the one that we already run in Zonemaster-Engine? |
e5ca6aa
to
e118c48
Compare
None, it's one or the other not both. |
@MichaelTimbert, as far as I can see this can be merged. |
Purpose
Propose an CI solution using github action.
If accepted this can close #195 and #119, since it is no longer necessary to test the MANIFEST in the test suite.
How to test this PR
Github action must be run when a push is made on [develop, master, releases] or when a pull request is requested.
This must run the test suite and fail if an error is reported.
Same if 'make distcheck' report missing files.