Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates dependencies for v2024.2 (v4.3.1) #485

Merged
merged 3 commits into from
Dec 9, 2024

Conversation

matsduf
Copy link
Contributor

@matsduf matsduf commented Dec 6, 2024

Purpose

This PR updates dependencies (package.json) to reduces warnings when building. It also includes the resulting package-lock.json to cache the result of npm audit fix.

This PR is built on top of commit 2c299b3 in #484, and the files from that are not included in this PR.

Changes

  • package.json
  • package-lock.json

How to test this PR

Verify that resulting package runs well. Use the zip file enclosed in the comment below.

@matsduf matsduf marked this pull request as draft December 6, 2024 21:37
@matsduf matsduf force-pushed the update-dependencies-for-v2024.2 branch from 13c871a to 9b5d32d Compare December 6, 2024 22:00
@matsduf
Copy link
Contributor Author

matsduf commented Dec 6, 2024

A zip file from this PR is included here. It will be the dist file unless there are any changes to this PR or #484.
zonemaster_web_gui-PR485-9b5d32d-2024-12-06.zip

@matsduf matsduf marked this pull request as ready for review December 6, 2024 22:18
@matsduf matsduf added P-High Priority: Issue to be solved before other V-Patch Versioning: The change gives an update of patch in version. labels Dec 6, 2024
@matsduf matsduf added this to the v2024.2 milestone Dec 6, 2024
marc-vanderwal
marc-vanderwal previously approved these changes Dec 9, 2024
tgreenx
tgreenx previously approved these changes Dec 9, 2024
@tgreenx tgreenx changed the base branch from master to develop December 9, 2024 10:48
@tgreenx tgreenx dismissed stale reviews from marc-vanderwal and themself December 9, 2024 10:48

The base branch was changed.

tgreenx
tgreenx previously approved these changes Dec 9, 2024
Copy link
Contributor

@tgreenx tgreenx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The base branch was set on master, I changed it to develop.

marc-vanderwal
marc-vanderwal previously approved these changes Dec 9, 2024
@matsduf matsduf dismissed stale reviews from marc-vanderwal and tgreenx December 9, 2024 12:41

The merge-base changed after approval.

@matsduf matsduf merged commit 43f0489 into zonemaster:develop Dec 9, 2024
1 check passed
@matsduf matsduf deleted the update-dependencies-for-v2024.2 branch December 9, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P-High Priority: Issue to be solved before other V-Patch Versioning: The change gives an update of patch in version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants