Close history modal #465
Merged
Close history modal #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannaeko
requested review from
mattias-p,
matsduf,
tgreenx and
marc-vanderwal
hannaeko
added
the
V-Patch
marc-vanderwal
previously approved these changes
Mar 6, 2024
tgreenx
previously approved these changes
May 14, 2024
|
Tested and working. |
|
@hannaeko, can you resolve the conflict? |
hannaeko
dismissed stale reviews from MichaelTimbert, tgreenx, and marc-vanderwal
via
ff1f0af
hannaeko
force-pushed
the
close-history-modal
branch
from
c421bea to
ff1f0af
Compare
The conflict has been resolved :) |
tgreenx
approved these changes
Jun 11, 2024
|
@matsduf @marc-vanderwal @MichaelTimbert please re-review, conflict has been fixed, this can then be merged. |
matsduf
approved these changes
Jun 11, 2024
tgreenx
added
the
S-ReleaseTested
v2024.1 Release testingWorks as advertised on Firefox, Debian 12. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
No indication (visual or not) are given to the user to signal that the new test results have been fetched.
Context
Fixes #242
Changes
Close the history modal when a link is clicked and move focus to the result heading (h2).
Limitation (maybe future work) : if the result request takes some time the focus would be moved to the old title and there would not be a indication when the new results have been received.
How to test this PR
(Better to test with a screen reader)