Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update translation doc #462

Merged
merged 5 commits into from
Jun 11, 2024
Merged

Conversation

hannaeko
Copy link
Member

Purpose

Update the translation guide to add a new language.

Context

#381

Changes

Update the zonemaster.conf-example section of the translation guide document.

How to test this PR

-

@hannaeko hannaeko added the A-Documentation Area: Documentation only. label Feb 26, 2024
@hannaeko hannaeko added this to the v2024.1 milestone Feb 26, 2024
@hannaeko hannaeko linked an issue Feb 27, 2024 that may be closed by this pull request
marc-vanderwal
marc-vanderwal previously approved these changes Mar 6, 2024
Copy link
Contributor

@marc-vanderwal marc-vanderwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

tgreenx
tgreenx previously approved these changes May 14, 2024
@tgreenx tgreenx added the V-Patch Versioning: The change gives an update of patch in version. label May 14, 2024
docs/TranslationGuide.md Outdated Show resolved Hide resolved
Makes instruction for updating zonemaster.conf-example simpler.
@matsduf matsduf dismissed stale reviews from tgreenx and marc-vanderwal via 4fe47ba June 3, 2024 13:57
matsduf
matsduf previously approved these changes Jun 3, 2024
@matsduf
Copy link
Contributor

matsduf commented Jun 3, 2024

I updated the PR with a commit. @tgreenx and @marc-vanderwal, please review.

Copy link
Contributor

@marc-vanderwal marc-vanderwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few typos.

matsduf and others added 2 commits June 4, 2024 12:05
Co-authored-by: Marc van der Wal <[email protected]>
Co-authored-by: Marc van der Wal <[email protected]>
@matsduf matsduf requested review from marc-vanderwal and tgreenx June 4, 2024 10:06
@tgreenx tgreenx merged commit 4ecb63f into zonemaster:develop Jun 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Documentation Area: Documentation only. V-Patch Versioning: The change gives an update of patch in version.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update translator doc
4 participants