Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add gui server #439

Draft
wants to merge 8 commits into
base: develop
Choose a base branch
from
Draft

Conversation

hannaeko
Copy link
Member

@hannaeko hannaeko commented Sep 7, 2023

Purpose

Add a basic web server to serve GUI files.

Context

Based on #434
Following a discussion in the face to face, we decided to serve the GUI from a server to allow more flexibility.

Changes

  • Add a server in perl (using Dancer2)
  • Template index.html to include additional resources and override default ones (for css)
  • Detect browser language using the server
  • Add Makefile.PL for packaging
  • Update reverse proxy documentation
  • Update installation doc in zonemaster/zonemaster repo
  • Add service script to manage daemon
  • Add example configuration and update configuration documentation
  • Remove unused files (configuration, scripts, ...)

How to test this PR

Running the server:

% plackup scripts/zonemaster-gui

@hannaeko hannaeko mentioned this pull request Oct 24, 2023
30 tasks
@hannaeko
Copy link
Member Author

This is still a draft as it is not finished, but I would like some early feedback to avoid going the wrong path.

@hannaeko
Copy link
Member Author

hannaeko commented Nov 2, 2023

Commit 80e36dd is the relevant stuff

@hannaeko
Copy link
Member Author

I still need architecture approval on this PR to finish (or change) this work.

Copy link
Contributor

@marc-vanderwal marc-vanderwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In terms of architecture, I see no issues; I agree with the choice of Dancer2.

lib/Zonemaster/GUI.pm Show resolved Hide resolved
@matsduf matsduf added this to the v2023.2 milestone Nov 22, 2023
@matsduf
Copy link
Contributor

matsduf commented Dec 13, 2023

Danser will create daemon listening to http, won't it? Will that be on localhost using apache as a reverse proxy? Will everything still be packaged in one zip file as today?

@marc-vanderwal
Copy link
Contributor

Dancer can spawn a small HTTP server for testing purposes, but when deploying a Dancer app in production, it can also spawn a FastCGI server, which is less expensive.

@hannaeko
Copy link
Member Author

hannaeko commented Dec 13, 2023

Danser will create daemon listening to http, won't it? Will that be on localhost using apache as a reverse proxy?

yes, there will be a reverse proxy in front either way

Will everything still be packaged in one zip file as today?

No it will be packaged as a perl module.

@hannaeko
Copy link
Member Author

I am delaying that for next release, I think this PR needs more thoughts.

@hannaeko hannaeko modified the milestones: v2023.2, v2024.1 Dec 19, 2023
@tgreenx tgreenx modified the milestones: v2024.1, v2024.2 Jun 11, 2024
@tgreenx tgreenx removed this from the v2024.2 milestone Sep 11, 2024
@tgreenx tgreenx added this to the v2025.1 milestone Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants