-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gui server #439
base: develop
Are you sure you want to change the base?
Add gui server #439
Conversation
This is still a draft as it is not finished, but I would like some early feedback to avoid going the wrong path. |
Commit 80e36dd is the relevant stuff |
I still need architecture approval on this PR to finish (or change) this work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In terms of architecture, I see no issues; I agree with the choice of Dancer2.
80e36dd
to
068110a
Compare
Danser will create daemon listening to http, won't it? Will that be on localhost using apache as a reverse proxy? Will everything still be packaged in one zip file as today? |
Dancer can spawn a small HTTP server for testing purposes, but when deploying a Dancer app in production, it can also spawn a FastCGI server, which is less expensive. |
yes, there will be a reverse proxy in front either way
No it will be packaged as a perl module. |
I am delaying that for next release, I think this PR needs more thoughts. |
Purpose
Add a basic web server to serve GUI files.
Context
Based on #434
Following a discussion in the face to face, we decided to serve the GUI from a server to allow more flexibility.
Changes
How to test this PR
Running the server: