-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perform a test through the URL directly #334
Merged
Merged
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
b93e27b
Deprecate "/domain_check" route
8a5b8df
Use route redirection for "/test/<test-id>"
9a55f79
Fetch domain name from URL route parameter
a4c5a5f
Populate form input with domain from URL
f296c36
Automatically run the test if a domain is provided
cc67b60
Update href to new /check path
43363e9
Fix e2e tests
8d0bb8a
Provide e2e redirection tests
9b52c19
Remove unused "/history" route
80c046e
Fix implementation
a473fb8
Remove unused property
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
const { test, expect } = require('@playwright/test'); | ||
|
||
import { goToHome, setLang } from './utils/app.utils'; | ||
|
||
test.describe('Redirection should properly work', () => { | ||
test.beforeEach(async ({ page }) => { | ||
await goToHome(page); | ||
await setLang(page, 'en'); | ||
}); | ||
|
||
test('/ should redirect to /check', async ({ page, baseURL }) => { | ||
await page.goto( baseURL + '/' ); | ||
await expect(page).toHaveURL( baseURL + '/check' ); | ||
}); | ||
|
||
test('/domain_check should redirect to /check', async ({ page, baseURL }) => { | ||
await page.goto( baseURL + '/domain_check' ); | ||
await expect(page).toHaveURL( baseURL + '/check' ); | ||
}); | ||
|
||
test('/test/<test-id> should redirect to /result/<test-id>', async ({ page, baseURL }) => { | ||
const testID = '226f6d4f44ae3f80'; | ||
|
||
await page.goto( baseURL + '/test/' + testID ); | ||
await expect(page).toHaveURL( baseURL + '/result/' + testID ); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the
domainName
property used anywhere else? If not would it make sense to remove it?