Skip to content

Commit

Permalink
fix misunderstanding about how people are using root
Browse files Browse the repository at this point in the history
  • Loading branch information
knzai committed Jul 9, 2024
1 parent 2058a61 commit c2f2f4e
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 17 deletions.
13 changes: 3 additions & 10 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,17 +9,13 @@ jobs:
submodules: true
ref: site
- uses: zolacti/on@main
test-with-root-not-in-root:
test-with-root:
runs-on: ubuntu-latest
steps:
#the deploy action requires checkout and it's messy to do a checkout in public first (gotta deal with deletes etc)
#so it's simpler to checkout in root first, then content in folder. Or just not use the root arg really.
- uses: actions/checkout@master
- uses: actions/checkout@master
with:
submodules: true
ref: site
path: docs
ref: docs-site
- uses: zolacti/on@main
with:
root: docs
Expand All @@ -31,7 +27,4 @@ jobs:
with:
folder: not-public
single-commit: true
branch: not-gh-pages



branch: not-gh-pages
8 changes: 1 addition & 7 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -148,21 +148,15 @@ jobs:
test:
runs-on: ubuntu-latest
steps:
#the deploy action requires a checkout and it's messy to do a checkout in public first (gotta deal with deletes etc)
#so it's simpler to checkout in root first, then content in folder. Or easier just don't use the root in such a way
#that you can't have it still be in the root of the repo. Just checkout docs into the root! But you can do it:
- uses: actions/checkout@master
- uses: actions/checkout@master
with:
ref: docs
path: docs
ref: docs-site #has the content in a docs folder
- uses: zolacti/on@main
with:
check: false
deploy: false
drafts: true
root: docs
- uses: actions/checkout@master #the deploy action requires a .git in root
- name: Deploy 🚀
uses: JamesIves/github-pages-deploy-action@v4
with:
Expand Down

0 comments on commit c2f2f4e

Please sign in to comment.