Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: non zero gas limit in options breaks transfer function #65

Conversation

comilao
Copy link
Contributor

@comilao comilao commented Apr 20, 2024

What πŸ’»

Allow to specify the gas limit when making a transfer tx

Why βœ‹

If tx.options.gas_limit is not 0, no tx_712 variable will be created and the function transfer() breaks at here

Evidence πŸ“·

Include screenshots, screen recordings, or console output here demonstrating that your changes work as intended

Notes πŸ“

  • Any notes/thoughts that the reviewers should know prior to reviewing the code?

@comilao comilao requested a review from a team as a code owner April 20, 2024 08:50
@petarTxFusion
Copy link
Contributor

Could you please install latest version of black and run black zksync2 scripts tests to resolve validate job

@comilao comilao force-pushed the fix/non-zero-gas-limit-breaks-transfer-function branch from 95faf9a to cf03db9 Compare April 24, 2024 13:25
@comilao
Copy link
Contributor Author

comilao commented Apr 24, 2024

Could you please install latest version of black and run black zksync2 scripts tests to resolve validate job

I see, thank you for this tip.
I just made the change and force push my branch.

@petarTxFusion petarTxFusion merged commit d739a60 into zksync-sdk:master Apr 24, 2024
4 checks passed
@comilao comilao deleted the fix/non-zero-gas-limit-breaks-transfer-function branch April 25, 2024 14:24
Copy link

github-actions bot commented Jun 7, 2024

πŸŽ‰ This PR is included in version 1.2.0 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

Copy link

github-actions bot commented Jun 7, 2024

πŸŽ‰ This PR is included in version 1.2.0 πŸŽ‰

The release is available on:

Your semantic-release bot πŸ“¦πŸš€

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants