Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: move to a modern EIP-712 structs module #51

Closed
wants to merge 3 commits into from
Closed

fix: move to a modern EIP-712 structs module #51

wants to merge 3 commits into from

Conversation

BoboTiG
Copy link
Contributor

@BoboTiG BoboTiG commented Jan 11, 2024 •
edited
Loading

What 💻

Why ✋

Notes 📝

The API does not change, it is a drop-in replacement, and as a bonus it unlocks Python 3.11 & 3.12 support.

@BoboTiG BoboTiG requested a review from a team as a code owner January 11, 2024 23:54
@BoboTiG
Copy link
Contributor Author

BoboTiG commented Jan 12, 2024

I updated the version + fixed the commit checker.

@BoboTiG
fix: move to a modern EIP-712 structs module
043d64b 
The API does not change, it is a drop-in replacement, and as a bonus:

- fixes #3
- fixes #43
- Python 3.11 & 3.12 support
@BoboTiG BoboTiG changed the title fix: Move to a modern EIP-712 structs module fix: move to a modern EIP-712 structs module Jan 12, 2024
@BoboTiG
Copy link
Contributor Author

BoboTiG commented Jan 12, 2024

Fixed the conflict 👍🏻

@petarTxFusion
Copy link
Contributor

Thank you for your efforts. We will have to reject this PR since we are trying to move away from this dependency.

@BoboTiG BoboTiG deleted the fix-new-eip712-module branch January 12, 2024 15:02
@BoboTiG
Copy link
Contributor Author

BoboTiG commented Jan 12, 2024

Noted 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pysha3 conflict Building wheel for bitarray (pyproject.toml) did not run successfully
2 participants
@BoboTiG @petarTxFusion