fix(wallet): fix maxPriorityFeePerGas hiegher than maxFeePerGas

zksync-sdk · Mar 15, 2024 · daaa783 · daaa783
1 parent 9fd3b23
commit daaa783
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 7 deletions.
diff --git a/src/main/java/io/zksync/ZkSyncWallet.java b/src/main/java/io/zksync/ZkSyncWallet.java
@@ -480,6 +480,10 @@ public RemoteCall<TransactionReceipt> sendMessageToL1(byte[] message, @Nullable
     }
 
     private CompletableFuture<EthSendTransaction> estimateAndSend(Transaction transaction, BigInteger nonce) {
+        return estimateAndSend(transaction, nonce, BigInteger.ZERO);
+    }
+
+    private CompletableFuture<EthSendTransaction> estimateAndSend(Transaction transaction, BigInteger nonce, BigInteger maxPriorityFeePerGas) {
         return CompletableFuture
                 .supplyAsync(() -> {
                     long chainId = signer.getDomain().join().getChainId().getValue().longValue();
@@ -493,7 +497,7 @@ private CompletableFuture<EthSendTransaction> estimateAndSend(Transaction transa
                             transaction.getTo(),
                             transaction.getValueNumber(),
                             transaction.getData(),
-                            BigInteger.valueOf(100000000L), // TODO: Estimate correct one
+                            maxPriorityFeePerGas,
                             gasPrice,
                             transaction.getFrom(),
                             transaction.getEip712Meta()
@@ -514,4 +518,4 @@ private CompletableFuture<EthSendTransaction> estimateAndSend(Transaction transa
                 });
     }
 
-}
+}
diff --git a/src/main/java/io/zksync/protocol/account/Wallet.java b/src/main/java/io/zksync/protocol/account/Wallet.java
@@ -112,11 +112,13 @@ public CompletableFuture<BigInteger> getDeploymentNonce(){
      */
     public RemoteCall<TransactionReceipt> transfer(TransferTransaction tx) {
         return new RemoteCall<>(() -> {
+            tx.options = tx.options == null ? new TransactionOptions() : tx.options;
+            BigInteger maxPriorityFeePerGas = tx.options.getMaxPriorityFeePerGas() == null ? BigInteger.ZERO : tx.options.getMaxPriorityFeePerGas();
             BigInteger nonceToUse = getNonce().send();
 
             Transaction estimate = providerL2.getTransferTransaction(tx, transactionManager, gasProvider);
 
-            EthSendTransaction sent = estimateAndSend(estimate, nonceToUse).join();
+            EthSendTransaction sent = estimateAndSend(estimate, nonceToUse, maxPriorityFeePerGas).join();
 
             try {
                 return this.transactionReceiptProcessor.waitForTransactionReceipt(sent.getTransactionHash());
@@ -135,11 +137,13 @@ public RemoteCall<TransactionReceipt> transfer(TransferTransaction tx) {
     public RemoteCall<TransactionReceipt> withdraw(WithdrawTransaction tx) {
         tx.tokenAddress = tx.tokenAddress == null ? ZkSyncAddresses.ETH_ADDRESS : tx.tokenAddress;
         tx.from = tx.from == null ? getAddress() : tx.from;
+        tx.options = tx.options == null ? new TransactionOptions() : tx.options;
+        BigInteger maxPriorityFeePerGas = tx.options.getMaxPriorityFeePerGas() == null ? BigInteger.ZERO : tx.options.getMaxPriorityFeePerGas();
 
         return new RemoteCall<>(() -> {
             Transaction transaction = providerL2.getWithdrawTransaction(tx, gasProvider, transactionManager);
 
-            EthSendTransaction sent = estimateAndSend(transaction, getNonce().send()).join();
+            EthSendTransaction sent = estimateAndSend(transaction, getNonce().send(), maxPriorityFeePerGas).join();
 
             try {
                 return this.transactionReceiptProcessor.waitForTransactionReceipt(sent.getTransactionHash());
@@ -390,8 +394,11 @@ public RemoteCall<TransactionReceipt> sendMessageToL1(byte[] message, @Nullable
         });
     }
 
-
     private CompletableFuture<EthSendTransaction> estimateAndSend(Transaction transaction, BigInteger nonce) {
+        return estimateAndSend(transaction, nonce, BigInteger.ZERO);
+    }
+
+    private CompletableFuture<EthSendTransaction> estimateAndSend(Transaction transaction, BigInteger nonce, BigInteger maxPriorityFeePerGas) {
         return CompletableFuture
                 .supplyAsync(() -> {
                     long chainId = providerL2.ethChainId().sendAsync().join().getChainId().longValue();
@@ -405,7 +412,7 @@ private CompletableFuture<EthSendTransaction> estimateAndSend(Transaction transa
                             transaction.getTo(),
                             transaction.getValueNumber(),
                             transaction.getData(),
-                            BigInteger.valueOf(100000000L), // TODO: Estimate correct one
+                            maxPriorityFeePerGas,
                             gasPrice,
                             transaction.getFrom(),
                             transaction.getEip712Meta()
@@ -424,4 +431,4 @@ private CompletableFuture<EthSendTransaction> estimateAndSend(Transaction transa
                     }
                 });
     }
-}
+}