Fix getSignInput bug for zero maxPriorityFeePerGas #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please fix commit message, we follow conventional commit messages, and check errors during build |
everdimension
force-pushed
the
fix/eip712signer-get-sign-input-bug
branch
2 times, most recently
from
ec2fcf2 to
3952b49
Compare
Explicit zero value should not fallback to maxFeePerGas
everdimension
force-pushed
the
fix/eip712signer-get-sign-input-bug
branch
from
3952b49 to
157620b
Compare
|
@petarTxFusion thx, done! |
|
@petarTxFusion It doesn't seem that failed tests are related, but maybe they are, can you check please? |
I will run them on the main branch so we can see |
|
Tests are passing on the main branch you can see it here. I will have to take a better look at your changes |
|
@petarTxFusion Thanks, great! Yes, please do. I added a test that should fail for current implementation |
|
Transaction constructor is also buggy, so: 1e8231e |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicit zero value should not fallback to maxFeePerGas
See zkSync-Community-Hub/zksync-developers#814
Please run the tests to verify, I haven't been able to run https://github.com/matter-labs/local-setup yet
More details in comment: zkSync-Community-Hub/zksync-developers#814 (comment)