Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Refactor #1

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

feat: Refactor #1

wants to merge 10 commits into from

Conversation

Bisht13
Copy link
Member

@Bisht13 Bisht13 commented Nov 22, 2024

No description provided.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bisht13

  1. // require(!nullifiers[handleString], "Unique handle required"); - why is this commented out - is it important?

  2. The logic for L45-L52
    and L54-L61 look identical although the comments suggest they should be different

  3. How is {{ field.name }}_string used? I cannot see it being used, is it meant to be used as part of the commented out nullifier logic?

  4. There is some validation that happens in Verifier.sol. This might be a trivial question, but for my understanding, do we need to do similar validation here such as:
    “invalid format of pA”
    ”invalid format of pB”
    “invalid format of pC”

  5. The template has the following argument uint[{{ signal_size }}] calldata signals. I assume this is equivalent to pubSignals that are dynamically constructed in the following Verifier.sol

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Ownable is used but cannot see reference to onlyOwner() - should onlyOwner() be used somewhere?

  2. nitpick - should contract Contract is Ownable { be something like contract Verifier is Ownable {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants