-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Refactor #1
base: main
Are you sure you want to change the base?
Conversation
circom/templates/contract.sol.tera
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
// require(!nullifiers[handleString], "Unique handle required");
- why is this commented out - is it important? -
The logic for L45-L52
and L54-L61 look identical although the comments suggest they should be different -
How is
{{ field.name }}_string
used? I cannot see it being used, is it meant to be used as part of the commented out nullifier logic? -
There is some validation that happens in Verifier.sol. This might be a trivial question, but for my understanding, do we need to do similar validation here such as:
“invalid format of pA”
”invalid format of pB”
“invalid format of pC” -
The template has the following argument
uint[{{ signal_size }}] calldata signals
. I assume this is equivalent topubSignals
that are dynamically constructed in the following Verifier.sol
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
Ownable
is used but cannot see reference toonlyOwner()
- shouldonlyOwner()
be used somewhere? -
nitpick - should
contract Contract is Ownable {
be something likecontract Verifier is Ownable {
No description provided.