Feat/oauth mvp test #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If caller calls another function which is not a basic ERC20 function, _execute allows user's action.
It checks the difference between amount in callData and tokenAmount
…/zk-email-wallet into feat/oauth-mvp-allowance
* Implement ERC20 functions. * Add test cases that's not implemented yet. * Update _execute function. If caller calls another function which is not a basic ERC20 function, _execute allows user's action. * Update _checkAllowanceReduction. It checks the difference between amount in callData and tokenAmount * Add return line into _execute function. * Simplify Wallet and add failing test cases --------- Co-authored-by: SoraSuegami <[email protected]>
…ail/zk-email-wallet into feat/oauth-mvp-contract-fix
|
@wshino can we fix the merge conflict here so we can merge |
@Divide-By-0 Sorry for the late reply. I fixed conflicts and failed tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.