fix: merges records with the same values #126
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes zkemail#122, i dont know if this is exactly what you wanted so you might have to review it, it merges records with the same values while keeping the earliest first seen at date with the oldest last seen at date.
|
const existing = valueMap.get(record.value)!; is wrong -- there may be multiple records. I'd prefer a script that goes through the DB and merges. |
|
Bump @hhuntaa, did you test this with a local copy of the database and how it performed? I'm worried that it didn't act correctly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #122, i dont know if this is exactly what you wanted so you might have to review it, it merges records with the same values while keeping the earliest first seen at date with the oldest last seen at date.