slf4j - cause to throwable using FiberFailure to have proper stacktrace

[justcoon]

No description provided.

[adamgfraser]

I wonder if this should just be FiberFailure(cause) and return a Throwable instead of an Option[Throwable]. A Cause.empty still means some failure occurred, it just means we don't have additional information about that failure.

[justcoon]

in current zio.ZLogger interface, Cause is always provided

trait ZLogger[-Message, +Output] { self =>
  def apply(
    trace: Trace,
    fiberId: FiberId,
    logLevel: LogLevel,
    message: () => Message,
    cause: Cause[Any],
    context: FiberRefs,
    spans: List[LogSpan],
    annotations: Map[String, String]
  ): Output
}

for example ZIO.logInfo("Start"):

considering zio.Cause.isEmpty implementation, is it better in case of causeToThrowableDefault to pattern match on zio.Cause.Empty ?

[adamgfraser]

Makes sense.