Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Parse passwords with arbitrary colons #3201

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

mobley-trent
Copy link

Closes #3193
/claim #3193

@mobley-trent mobley-trent marked this pull request as ready for review November 9, 2024 10:02
@mobley-trent
Copy link
Author

mobley-trent commented Nov 11, 2024

AuthSpec test suite is passing locally, is it a flaky test suite ?

@mobley-trent
Copy link
Author

@987Nabil kindly review

@mobley-trent
Copy link
Author

PTAL @jdegoes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parsing a Basic Authorization header fails if password contains ':'
2 participants