Exclude sourcecode from scalameta parsers
#3195
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh. Production code depends on other parts of scalameta. Perhaps I should add another exclusion then. |
nafg
commented
Oct 31, 2024
nafg
changed the title
sourcecode from scalameta parsers
nafg
commented
Oct 31, 2024
|
I don't think the remaining failures have to do with this change |
|
The commits should probably be squashed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because it pulls in
sourcecodefor Scala 2.13 even on Scala 3, this just wasted a lot of my time trying to figure out why I was getting bizarre errors caused by Scala 3 not being able to run Scala 2 macros.