Alternative literal path segments for route definitions (#2815) #2920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdegoes
reviewed
Jun 19, 2024
jdegoes
reviewed
Jun 19, 2024
| @@ -458,6 +530,7 @@ object PathCodec { | |||
| private[http] sealed trait Opt | |||
| private[http] object Opt { | |||
| final case class Match(value: String) extends Opt | |||
| final case class MatchAny(values: Set[String]) extends Opt | |||
There was a problem hiding this comment.
Good to use a set here. We can do even better than that by producing a finite state machine that produces true for a match, and false otherwise (due to the char-by-char nature of testing for string equality). But, separate issue and PR. 😄
There was a problem hiding this comment.
You mean some structure, where we have like n states, where n is max length of the alternatives and there is a way to progress to the next state with the right char, true if the string ends or false for any other char, right?
jdegoes
requested changes
Jun 19, 2024
987Nabil
force-pushed
the
alternative-path-segments
branch
4 times, most recently
from
f9fc488 to
f7c392e
Compare
987Nabil
force-pushed
the
alternative-path-segments
branch
from
f7c392e to
a44bd4d
Compare
jdegoes
approved these changes
Jun 23, 2024
jdegoes
approved these changes
Jun 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2815
/claim #2815