Add routes#serve method #2829
Add routes#serve method #2829
Conversation
|
|
GrigoriiBerezin
force-pushed
the
add_routes_serve_method
branch
from
fd14079 to
b8ac0e2
Compare
| @@ -282,6 +282,10 @@ object Routes extends RoutesCompanionVersionSpecific { | |||
| def singleton[Env, Err](h: Handler[Env, Err, (Path, Request), Response])(implicit trace: Trace): Routes[Env, Err] = | |||
| Routes(Route.route(RoutePattern.any)(h)) | |||
|
|
|||
| implicit class RouteOps[-Env, +Err <: Response](val routes: Routes[Env, Err]) extends AnyVal { | |||
| def serve: URIO[Env with Server, Int] = Server.install(routes) | |||
There was a problem hiding this comment.
Since the focus here is on usability, I think this should be calling Server.serve instead, so users don't have to call ZIO.never afterwards. I believe this was what the issue was aiming for as well
There was a problem hiding this comment.
Oh, I get it, my bad, thx for notice
| @@ -282,6 +282,10 @@ object Routes extends RoutesCompanionVersionSpecific { | |||
| def singleton[Env, Err](h: Handler[Env, Err, (Path, Request), Response])(implicit trace: Trace): Routes[Env, Err] = | |||
| Routes(Route.route(RoutePattern.any)(h)) | |||
|
|
|||
| implicit class RouteOps[-Env, +Err <: Response](val routes: Routes[Env, Err]) extends AnyVal { | |||
There was a problem hiding this comment.
By the way sorry if this a stupid question, but do we need the implicit class? Isn't possible to have this as a method directly implemented on Routes instead or am I missing something?
There was a problem hiding this comment.
Just wanted to have implementations of server far from route implementation, mb I'm wrong
There was a problem hiding this comment.
This seems to be valid, but I am uncertain if it provides any significant advantages.
There was a problem hiding this comment.
Should I move it into implementation?
There was a problem hiding this comment.
No implicit. Just a method on routes
There was a problem hiding this comment.
I've done it, but now it's failing with handshake test for some reason
GrigoriiBerezin
force-pushed
the
add_routes_serve_method
branch
6 times, most recently
from
c6dadc4 to
26f546e
Compare
GrigoriiBerezin
force-pushed
the
add_routes_serve_method
branch
from
4d990c8 to
03762b7
Compare
|
Finally have fixed all issues |
No description provided.