Simplify running ZIO effects #2828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Flaky test seems to strike again. Probably just needs a retry but I don't have the right permissions to do it |
|
@kyri-petrou I can't remember I saw that test failing before. I merged main. Let's see what's the outcome |
jdegoes
approved these changes
May 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heya folks, I've noticed that there are a few places where ZIO effects are run "synchronously" either unnecessarily or not composed together, so I thought to make a PR for it.
Also, I removed the
NettyRuntime#runtimemethod as discussed here: #2800 (comment). This also allows us to do an ultra-micro-optimization by not having to create theRuntime#UnsafeAPIon each invocation ofrun