Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Diagrams for ProtocolStack, HandlerAspect and Middleware #2826

Merged
merged 2 commits into from
May 16, 2024

Conversation

khajavi
Copy link
Member

@khajavi khajavi commented May 7, 2024

No description provided.

@khajavi khajavi requested review from jdegoes, vigoo and 987Nabil as code owners May 7, 2024 11:20
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.28%. Comparing base (65dc08d) to head (79d52e0).
Report is 2 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2826   +/-   ##
=======================================
  Coverage   64.28%   64.28%           
=======================================
  Files         155      155           
  Lines        9086     9086           
  Branches     1586     1586           
=======================================
  Hits         5841     5841           
  Misses       3245     3245           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@987Nabil
Copy link
Contributor

987Nabil commented May 7, 2024

I wonder if this is not too much? I mean all images basically look the same. Is there any significant difference?

@khajavi
Copy link
Member Author

khajavi commented May 7, 2024

I wonder if this is not too much? I mean all images basically look the same. Is there any significant difference?

The overall structure is the same, but each data type has its unique features e.g. the ProtocolStack is not fixed by Request and Response, the HandlerAspect is fixed but also has the OutCtx and finally the Middleware which has fixed its inputs and outputs, but not have any context and can be applied to route/routes. Looking at each data type diagram, the reader can quickly grasp the concept or may want to compare them with others.

@987Nabil 987Nabil merged commit ac358fa into zio:main May 16, 2024
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants