Deprecate HttpApp and remove internal usage. #2791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
987Nabil
changed the title
khajavi
reviewed
Apr 22, 2024
docs/dsl/handler_aspect.md
Outdated
| @@ -232,9 +233,11 @@ val intAspect: HandlerAspect[Any, Int] = HandlerAspect.identity.as(42) | |||
| To access this integer value in the handler, we need to define a handler that receives a tuple of `(Int, Request)`: | |||
|
|
|||
There was a problem hiding this comment.
The description of the snippet is required to be refactored.
khajavi
reviewed
Apr 22, 2024
docs/dsl/handler_aspect.md
Outdated
| @@ -258,9 +261,10 @@ val intStringAspect: HandlerAspect[Any, (Int, String)] = | |||
| Correspondingly, to access the output context of this `HandlerAspect`, we need to have a handler that receives a tuple of `(Int, String, Request)`: | |||
|
|
|||
khajavi
approved these changes
Apr 22, 2024
|
@987Nabil I noticed you kept |
|
@jdegoes I'll switch it around |
987Nabil
changed the title
987Nabil
force-pushed
the
eliminate-routes
branch
2 times, most recently
from
a6e9282 to
aac2912
Compare
khajavi
reviewed
Apr 23, 2024
docs/dsl/routes.md
Outdated
| @@ -195,34 +195,18 @@ trait Routes[-Env, +Err] { | |||
| } | |||
| ``` | |||
|
|
|||
| ## Converting `Routes` to `HttpApp` | |||
|
|
|||
There was a problem hiding this comment.
Instead of removing this section, I think we can refactor it and move it to the serving section to explain why we need handled routes to serve them.
|
@987Nabil Let me know when build is passing so we can get this in sooner rather than later. |
987Nabil
force-pushed
the
eliminate-routes
branch
5 times, most recently
from
b8c3b92 to
6855895
Compare
987Nabil
force-pushed
the
eliminate-routes
branch
from
6855895 to
da912a0
Compare
|
@jdegoes build is green |
jdegoes
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that Routes and HttpApp are at the end just two wrappers aroud a set of routes. Therefore this PR tries to simplify the structure