-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error handling methods on Route
/Routes
that can access Request
#2546
Conversation
743e301
to
ea5e790
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2546 +/- ##
==========================================
- Coverage 64.28% 64.27% -0.02%
==========================================
Files 138 138
Lines 7977 8013 +36
Branches 1483 1457 -26
==========================================
+ Hits 5128 5150 +22
- Misses 2849 2863 +14 ☔ View full report in Codecov by Sentry. |
ea5e790
to
d6dbc78
Compare
* used to convert a route that does not handle its errors into one that does | ||
* handle its errors. | ||
*/ | ||
final def handleErrorRequest(f: (Err, Request) => Response)(implicit trace: Trace): Route[Env, Nothing] = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One can argue that handleError with Request could be useful in non-cause scenarios, which would argue for the naming convention of handleError[Request][Cause]
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
handleError[Request][Cause][ZIO]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jdegoes done
Bug fix on Warning header
d6dbc78
to
43da2dd
Compare
Bug fix on Warning header