Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added all htmx attributes #2540

Closed
wants to merge 6 commits into from

Conversation

THM068
Copy link

@THM068 THM068 commented Nov 29, 2023

This PR is to add htmx attributes to the zio http. This will enable users to create interactive application using the backend.
You will need to pull the htmx javascript to make the attributes functional.

@CLAassistant
Copy link

CLAassistant commented Nov 29, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ THM068
✅ jdegoes
❌ Thando Mafela


Thando Mafela seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov-commenter
Copy link

codecov-commenter commented Nov 29, 2023

Codecov Report

Attention: 33 lines in your changes are missing coverage. Please review.

Comparison is base (f9ffb0b) 64.58% compared to head (647ec17) 64.33%.

Files Patch % Lines
.../main/scala/zio/http/template/HtmxAttributes.scala 0.00% 33 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2540      +/-   ##
==========================================
- Coverage   64.58%   64.33%   -0.26%     
==========================================
  Files         138      139       +1     
  Lines        8086     8119      +33     
  Branches     1459     1459              
==========================================
+ Hits         5222     5223       +1     
- Misses       2864     2896      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@guersam
Copy link
Contributor

guersam commented Dec 1, 2023

This update introduces htmx attributes for every user who imports zio.http.template._, even when htmx is not used.

I believe it would be more appropriate to use zio.http.template.htmx, ideally in a separate (sub)project, to provide enhanced convenience for htmx usage.

@jdegoes
Copy link
Member

jdegoes commented Dec 8, 2023

@THM068 I think it makes sense to put into a separate project but can live inside this repo if you like (zio-http-htmx?). What do you think?

@THM068
Copy link
Author

THM068 commented Dec 11, 2023

@THM068 I think it makes sense to put into a separate project but can live inside this repo if you like (zio-http-htmx?). What do you think?

Make sense, I will do that

@jdegoes
Copy link
Member

jdegoes commented Dec 20, 2023

@THM068 I will close for now, please re-open when it's in a separate submodule of this repository, linked into root project. Thanks for your work on this!

@jdegoes jdegoes closed this Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants