Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stream delay 3 #2458

Merged
merged 2 commits into from
Sep 24, 2023
Merged

Fix stream delay 3 #2458

merged 2 commits into from
Sep 24, 2023

Conversation

guersam
Copy link
Contributor

@guersam guersam commented Sep 24, 2023

I opened #2420 from the same branch as #2386, but somehow the patch was containing the first approach instead of the second one we discussed.

I thought I had double checked it but maybe I didn't... Sorry for the inconvenience.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01% 🎉

Comparison is base (70aabfc) 64.29% compared to head (c20d756) 64.30%.
Report is 2 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2458      +/-   ##
==========================================
+ Coverage   64.29%   64.30%   +0.01%     
==========================================
  Files         135      135              
  Lines        7113     7115       +2     
  Branches     1290     1285       -5     
==========================================
+ Hits         4573     4575       +2     
  Misses       2540     2540              
Files Changed Coverage Δ
...in/scala/zio/http/netty/NettyResponseEncoder.scala 90.00% <ø> (-0.91%) ⬇️
...rc/main/scala/zio/http/netty/NettyBodyWriter.scala 34.37% <100.00%> (+2.11%) ⬆️
...a/zio/http/netty/client/ClientInboundHandler.scala 95.45% <100.00%> (ø)
...a/zio/http/netty/server/ServerInboundHandler.scala 86.40% <100.00%> (+0.33%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jdegoes jdegoes merged commit 04e702c into zio:main Sep 24, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants