added cookie helpers #2439
Merged
added cookie helpers #2439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomTriple
requested review from
amitksingh1490,
jdegoes,
vigoo and
adamgfraser
as code owners
TomTriple
force-pushed
the
add-cookie-helper
branch
from
f23fd0f to
bcebcbd
Compare
Codecov ReportPatch coverage:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #2439 +/- ##
==========================================
+ Coverage 64.28% 64.76% +0.48%
==========================================
Files 135 135
Lines 7101 7133 +32
Branches 1211 1200 -11
==========================================
+ Hits 4565 4620 +55
+ Misses 2536 2513 -23
☔ View full report in Codecov by Sentry. |
|
|
TomTriple
force-pushed
the
add-cookie-helper
branch
2 times, most recently
from
69eb79f to
1de88cb
Compare
TomTriple
force-pushed
the
add-cookie-helper
branch
from
1de88cb to
64e128c
Compare
jdegoes
reviewed
Sep 24, 2023
| /** | ||
| * Uses the cookie with the given name if it exists and runs `f` afterwards. | ||
| */ | ||
| def cookieWith[R, A](name: String)(f: Cookie => ZIO[R, Throwable, A])(implicit trace: Trace): ZIO[R, Throwable, A] = |
jdegoes
reviewed
Sep 24, 2023
| /** | ||
| * Returns all cookies from the request. | ||
| */ | ||
| def cookies: Option[NonEmptyChunk[Cookie]] = |
There was a problem hiding this comment.
Suggested change
| def cookies: Option[NonEmptyChunk[Cookie]] = | |
| def cookies: Chunk[Cookie] = |
jdegoes
reviewed
Sep 24, 2023
| * Also, you can replace a `NoSuchElementException` from an absent cookie with | ||
| * `E`. | ||
| */ | ||
| def cookieWithOrFail[R, E, A](name: String)(e: E)(f: Cookie => ZIO[R, E, A])(implicit trace: Trace): ZIO[R, E, A] = |
There was a problem hiding this comment.
Suggested change
| def cookieWithOrFail[R, E, A](name: String)(e: E)(f: Cookie => ZIO[R, E, A])(implicit trace: Trace): ZIO[R, E, A] = | |
| def cookieWithOrFail[R, E, A](name: String)(missingCookieError: E)(f: Cookie => ZIO[R, E, A])(implicit trace: Trace): ZIO[R, E, A] = |
|
I added all your suggestions! |
987Nabil
requested changes
Sep 25, 2023
| private def cookieWithOrFailImpl[R, E, A](name: String)(e: Throwable => E)(f: Cookie => ZIO[R, E, A])(implicit | ||
| trace: Trace, | ||
| ): ZIO[R, E, A] = | ||
| ZIO.getOrFailWith(e(new java.util.NoSuchElementException(s"cookie doesn't exist: $name")))(cookie(name)).flatMap(f) |
There was a problem hiding this comment.
This will create an exception with stacktrace just to be thrown away immediately. This does not seem to be efficient.
I'd change it just simply to
Suggested change
| ZIO.getOrFailWith(e(new java.util.NoSuchElementException(s"cookie doesn't exist: $name")))(cookie(name)).flatMap(f) | |
| cookie(name) match { | |
| case Some(cookie) => f(e) | |
| case None => ZIO.fail(e) | |
| } |
where e is not a function
There was a problem hiding this comment.
Added your suggestions, thank you!
TomTriple
force-pushed
the
add-cookie-helper
branch
from
ae1c681 to
1c8f53b
Compare
jdegoes
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the operators are ok I'll send another PR with updated docs