simplified project directory injection

zikula-modules · May 31, 2020 · dfee228 · dfee228
1 parent 03d3caa
commit dfee228
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 13 deletions.
diff --git a/Bridge/ProfileModuleBridge.php b/Bridge/ProfileModuleBridge.php
@@ -16,7 +16,6 @@
 use InvalidArgumentException;
 use Symfony\Component\HttpFoundation\RequestStack;
 use Symfony\Component\Routing\RouterInterface;
-use Zikula\Bundle\CoreBundle\HttpKernel\ZikulaHttpKernelInterface;
 use Zikula\ExtensionsModule\Api\ApiInterface\VariableApiInterface;
 use Zikula\ProfileModule\Helper\GravatarHelper;
 use Zikula\ProfileModule\ProfileConstant;
@@ -28,11 +27,6 @@
 
 class ProfileModuleBridge implements ProfileModuleInterface
 {
-    /**
-     * @var ZikulaHttpKernelInterface
-     */
-    private $kernel;
-
     /**
      * @var RouterInterface
      */
@@ -63,28 +57,33 @@ class ProfileModuleBridge implements ProfileModuleInterface
      */
     private $gravatarHelper;
 
+    /**
+     * @var string
+     */
+    private $projectDir;
+
     /**
      * @var string
      */
     private $prefix;
 
     public function __construct(
-        ZikulaHttpKernelInterface $kernel,
         RouterInterface $router,
         RequestStack $requestStack,
         VariableApiInterface $variableApi,
         CurrentUserApiInterface $currentUser,
         UserRepositoryInterface $userRepository,
         GravatarHelper $gravatarHelper,
+        string $projectDir,
         $prefix
     ) {
-        $this->kernel = $kernel;
         $this->router = $router;
         $this->requestStack = $requestStack;
         $this->variableApi = $variableApi;
         $this->currentUser = $currentUser;
         $this->userRepository = $userRepository;
         $this->gravatarHelper = $gravatarHelper;
+        $this->projectDir = $projectDir;
         $this->prefix = $prefix;
     }
 
@@ -130,7 +129,7 @@ public function getAvatar($uid = null, array $parameters = []): string
 
         $avatarUrl = '';
         if (!in_array($avatar, ['blank.gif', 'blank.jpg'], true)) {
-            if (isset($avatar) && !empty($avatar) && $avatar !== $gravatarImage && file_exists($this->kernel->getProjectDir() . '/' . $avatarPath . '/' . $avatar)) {
+            if (isset($avatar) && !empty($avatar) && $avatar !== $gravatarImage && file_exists($this->projectDir . '/' . $avatarPath . '/' . $avatar)) {
                 $request = $this->requestStack->getCurrentRequest();
                 if (null !== $request) {
                     $avatarUrl = $request->getSchemeAndHttpHost() . $request->getBasePath() . '/' . $avatarPath . '/' . $avatar;

diff --git a/Form/Type/AvatarType.php b/Form/Type/AvatarType.php
@@ -18,7 +18,6 @@
 use Symfony\Component\Form\Extension\Core\Type\ChoiceType;
 use Symfony\Component\Form\Extension\Core\Type\FileType;
 use Symfony\Component\OptionsResolver\OptionsResolver;
-use Zikula\Bundle\CoreBundle\HttpKernel\ZikulaHttpKernelInterface;
 use Zikula\ExtensionsModule\Api\ApiInterface\VariableApiInterface;
 use Zikula\UsersModule\Constant as UsersConstant;
 
@@ -35,11 +34,11 @@ class AvatarType extends AbstractType
     private $avatarPath;
 
     public function __construct(
-        ZikulaHttpKernelInterface $kernel,
-        VariableApiInterface $variableApi
+        VariableApiInterface $variableApi,
+        string $projectDir
     ) {
         $this->modVars = $variableApi->getAll('ZikulaProfileModule');
-        $this->avatarPath = $kernel->getProjectDir() . '/' . $variableApi->get(UsersConstant::MODNAME, 'avatarpath', 'public/uploads/avatar');
+        $this->avatarPath = $projectDir . '/' . $variableApi->get(UsersConstant::MODNAME, 'avatarpath', 'public/uploads/avatar');
     }
 
     public function configureOptions(OptionsResolver $resolver)

diff --git a/Resources/config/services.yaml b/Resources/config/services.yaml
@@ -9,6 +9,7 @@ services:
         bind:
             $extension: '@Zikula\ProfileModule\ZikulaProfileModule'
             $prefix: '%zikula_profile_module.property_prefix%'
+            $projectDir: '%kernel.project_dir%'
 
     Zikula\ProfileModule\:
         resource: '../../*'