This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
zfcampus/zf-configuration 1.3.1 - breaks apigility admin #378
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As noted in zfcampus/zf-configuration#28 seems that
zfcampus/zf-configuration 1.3.1
break Apigility admin.This PR should prove this - I've updated composer.lock to zf-configuration 1.3.0 so tests will run with the following version of zf-configuration:
The change which break Apigility admin at this point was made be me in zfcampus/zf-configuration#25
I think the behaviour of zf-configuration was wrong, the method was not tested and documented, but unfortunately this wrong behaviour has been used in other components.
The simplest solution will be revert change introduced in zf-configuration 1.3.1 and fix it in 2.0.0.
See also:
zfcampus/zf-apigility-doctrine#295
zfcampus/zf-apigility-doctrine#296
zfcampus/zf-configuration#21
/cc @weierophinney @samsonasik @developer-devPHP