Skip to content
This repository has been archived by the owner on Jan 21, 2020. It is now read-only.

zfcampus/zf-configuration 1.3.1 - breaks apigility admin #378

Merged
merged 4 commits into from
Nov 14, 2017
Merged

zfcampus/zf-configuration 1.3.1 - breaks apigility admin #378

merged 4 commits into from
Nov 14, 2017

Conversation

michalbundyra
Copy link
Member

As noted in zfcampus/zf-configuration#28 seems that zfcampus/zf-configuration 1.3.1 break Apigility admin.

This PR should prove this - I've updated composer.lock to zf-configuration 1.3.0 so tests will run with the following version of zf-configuration:

  • 1.2.1 - lowest ✅
  • 1.3.0 - locked ✅
  • 1.3.1 - latest ❌

The change which break Apigility admin at this point was made be me in zfcampus/zf-configuration#25

I think the behaviour of zf-configuration was wrong, the method was not tested and documented, but unfortunately this wrong behaviour has been used in other components.
The simplest solution will be revert change introduced in zf-configuration 1.3.1 and fix it in 2.0.0.

See also:
zfcampus/zf-apigility-doctrine#295
zfcampus/zf-apigility-doctrine#296
zfcampus/zf-configuration#21

/cc @weierophinney @samsonasik @developer-devPHP

@weierophinney
Copy link
Member

This needs to be updated to prevent usage of the 1.3.1 version within the composer.json:

"zfcampus/zf-configuration": ">=1.2.1, <1.3.1, >1.3.1, <2.0"

This will ensure that 1.3.1, the current latest version, will never be installed.

zfcampus/zf-configuration 1.3.1 - breaks apigility admin
Allows 1.2.1 - 1.3.0 OR versions greater than 1.3.1 and less than 2.0.
Updates travis configuration to vary how dependencies are installed
based on PHP version.
@weierophinney weierophinney merged commit 8e3173f into zfcampus:master Nov 14, 2017
weierophinney added a commit that referenced this pull request Nov 14, 2017
weierophinney added a commit that referenced this pull request Nov 14, 2017
Forward port #378

Conflicts:
	CHANGELOG.md
@weierophinney
Copy link
Member

Thanks, @webimpress. I have added the appropriate constraint, and ensured tests pass at this time.

@michalbundyra michalbundyra deleted the test/zf-configuration branch November 14, 2017 21:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants