-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add deposit fee and audit fixes #66
Conversation
skosito
commented
Nov 30, 2024
- add configurable deposit fee used in deposit/deposit spl instruction, initialize to 0.002 SOL (for already deployed contracts have to be called with authority)
- save bumps in pdas
- check if receiver is empty address for deposits
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #66 +/- ##
========================================
- Coverage 6.53% 6.32% -0.21%
========================================
Files 1 1
Lines 398 411 +13
========================================
Hits 26 26
- Misses 372 385 +13 ☔ View full report in Codecov by Sentry. |
Just to confirm, it fixes https://github.com/zeta-chain/protocol-private/issues/186 and https://github.com/zeta-chain/protocol-private/issues/184? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
yes and this one https://github.com/zeta-chain/protocol-private/issues/188 to make sure tests are working as intended |