Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add deposit fee and audit fixes #66

Merged
merged 8 commits into from
Dec 2, 2024
Merged

fix: add deposit fee and audit fixes #66

merged 8 commits into from
Dec 2, 2024

Conversation

skosito
Copy link
Contributor

@skosito skosito commented Nov 30, 2024

  • add configurable deposit fee used in deposit/deposit spl instruction, initialize to 0.002 SOL (for already deployed contracts have to be called with authority)
  • save bumps in pdas
  • check if receiver is empty address for deposits

@codecov-commenter
Copy link

codecov-commenter commented Nov 30, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 6.32%. Comparing base (2c18683) to head (af5caec).

Files with missing lines Patch % Lines
programs/protocol-contracts-solana/src/lib.rs 0.00% 15 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##            main     #66      +/-   ##
========================================
- Coverage   6.53%   6.32%   -0.21%     
========================================
  Files          1       1              
  Lines        398     411      +13     
========================================
  Hits          26      26              
- Misses       372     385      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lumtis
Copy link
Member

lumtis commented Dec 2, 2024

Copy link
Contributor

@brewmaster012 brewmaster012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

programs/protocol-contracts-solana/src/lib.rs Outdated Show resolved Hide resolved
programs/protocol-contracts-solana/src/lib.rs Outdated Show resolved Hide resolved
@skosito
Copy link
Contributor Author

skosito commented Dec 2, 2024

zeta-chain/protocol-private#184

yes and this one https://github.com/zeta-chain/protocol-private/issues/188 to make sure tests are working as intended

programs/protocol-contracts-solana/src/lib.rs Outdated Show resolved Hide resolved
@skosito skosito merged commit 7fb0a66 into main Dec 2, 2024
14 checks passed
@skosito skosito deleted the deposit-fee branch December 2, 2024 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants