feat: enable tss auth on spl whitelisting #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skosito
requested review from
brewmaster012,
lumtis,
fbac and
ws4charlie
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #60 +/- ##
========================================
- Coverage 8.17% 6.53% -1.65%
========================================
Files 1 1
Lines 318 398 +80
========================================
Hits 26 26
- Misses 292 372 +80 ☔ View full report in Codecov by Sentry. |
5 tasks
lumtis
reviewed
Oct 31, 2024
brewmaster012
approved these changes
Oct 31, 2024
lumtis
approved these changes
Nov 1, 2024
skosito
force-pushed
the
enable-tss-auth-on-spl-whitelisting
branch
from
b321f9d to
442f381
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, whitelisting has only authority check, or equivalent to admin role in evm contracts. Zetaclient is signing with tss, so whitelist should be allowed for both authority and tss, this PR modifies that.
Testing currently with this draft PR where tss signature is used for whitelisting: zeta-chain/node#2984, and added unit tests here to verify both tss and authority work.