Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: look into Solana program log message to determine SPL token withdrawal failure #3231

Closed
wants to merge 8 commits into from

add changelog entry

632ee11
Select commit
Loading
Failed to load commit list.
Closed

fix: look into Solana program log message to determine SPL token withdrawal failure #3231

add changelog entry
632ee11
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 28, 2024 in 0s

62.00% (-0.01%) compared to 08ff881

View this Pull Request on Codecov

62.00% (-0.01%) compared to 08ff881

Details

Codecov Report

Attention: Patch coverage is 56.52174% with 10 lines in your changes missing coverage. Please review.

Project coverage is 62.00%. Comparing base (08ff881) to head (632ee11).

Files with missing lines Patch % Lines
pkg/contracts/solana/instruction.go 64.70% 6 Missing ⚠️
zetaclient/chains/solana/observer/outbound.go 33.33% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3231      +/-   ##
===========================================
- Coverage    62.00%   62.00%   -0.01%     
===========================================
  Files          428      428              
  Lines        30469    30482      +13     
===========================================
+ Hits         18891    18899       +8     
- Misses       10738    10743       +5     
  Partials       840      840              
Files with missing lines Coverage Δ
zetaclient/chains/solana/observer/outbound.go 25.81% <33.33%> (-1.01%) ⬇️
pkg/contracts/solana/instruction.go 28.23% <64.70%> (+9.66%) ⬆️