Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid endless tx rescan when the inbound vote message is invalid #3184

Merged

Merge branch 'develop' into avoid-btc-solana-inbound-endless-rescan-o…

c933432
Select commit
Loading
Failed to load commit list.
Merged

fix: avoid endless tx rescan when the inbound vote message is invalid #3184

Merge branch 'develop' into avoid-btc-solana-inbound-endless-rescan-o…
c933432
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 22, 2024 in 1s

62.41% (-0.34%) compared to cda3398

View this Pull Request on Codecov

62.41% (-0.34%) compared to cda3398

Details

Codecov Report

Attention: Patch coverage is 83.33333% with 16 lines in your changes missing coverage. Please review.

Project coverage is 62.41%. Comparing base (cda3398) to head (c933432).

Files with missing lines Patch % Lines
zetaclient/chains/solana/observer/inbound.go 87.09% 3 Missing and 1 partial ⚠️
zetaclient/chains/evm/observer/v2_inbound.go 0.00% 3 Missing ⚠️
...taclient/chains/evm/observer/v2_inbound_tracker.go 0.00% 3 Missing ⚠️
zetaclient/types/event.go 89.65% 2 Missing and 1 partial ⚠️
zetaclient/chains/bitcoin/observer/event.go 92.30% 1 Missing ⚠️
zetaclient/chains/bitcoin/observer/inbound.go 50.00% 1 Missing ⚠️
zetaclient/chains/bitcoin/signer/signer.go 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #3184      +/-   ##
===========================================
- Coverage    62.74%   62.41%   -0.34%     
===========================================
  Files          425      426       +1     
  Lines        30231    30258      +27     
===========================================
- Hits         18969    18885      -84     
- Misses       10425    10542     +117     
+ Partials       837      831       -6     
Files with missing lines Coverage Δ
x/crosschain/types/message_vote_inbound.go 100.00% <ø> (ø)
zetaclient/chains/base/observer.go 85.36% <100.00%> (+0.25%) ⬆️
zetaclient/compliance/compliance.go 14.28% <ø> (+3.86%) ⬆️
zetaclient/chains/bitcoin/observer/event.go 95.65% <92.30%> (-0.10%) ⬇️
zetaclient/chains/bitcoin/observer/inbound.go 32.92% <50.00%> (+0.86%) ⬆️
zetaclient/chains/bitcoin/signer/signer.go 18.15% <0.00%> (ø)
zetaclient/chains/evm/observer/v2_inbound.go 0.00% <0.00%> (ø)
...taclient/chains/evm/observer/v2_inbound_tracker.go 0.00% <0.00%> (ø)
zetaclient/types/event.go 89.65% <89.65%> (ø)
zetaclient/chains/solana/observer/inbound.go 37.05% <87.09%> (+4.55%) ⬆️

... and 5 files with indirect coverage changes

---- 🚨 Try these New Features: