Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(zetaclient): Revamp TSS package #3170

Merged
merged 40 commits into from
Nov 25, 2024

Fix btc issue

2c02cc2
Select commit
Loading
Failed to load commit list.
Merged

feat(zetaclient): Revamp TSS package #3170

Fix btc issue
2c02cc2
Select commit
Loading
Failed to load commit list.
GitGuardian / GitGuardian Security Checks failed Nov 22, 2024 in 1s

3 secrets uncovered!

3 secrets were uncovered from the scan of 40 commits in your pull request. ❌

Please have a look to GitGuardian findings and remediate in order to secure your code.

Details

🔎 Detected hardcoded secrets in your pull request

  • Pull request #3170: feat/zetaclient/tss-improvements 👉 develop
GitGuardian id GitGuardian status Secret Commit Filename
14567965 Triggered Generic Password c5b10c6 cmd/zetaclientd/start.go View secret
14567965 Triggered Generic Password ade21aa cmd/zetaclientd/start.go View secret
14567965 Triggered Generic Password c5b10c6 cmd/zetaclientd/start.go View secret

🛠 Guidelines to remediate hardcoded secrets

  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.