fix(ci): move skip_checks to step #3163
Conversation
📝 WalkthroughWalkthroughThe pull request introduces modifications to the Changes
Possibly related PRs
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
gartnera
force-pushed
the
fix-publish-release-skip-checks
branch
from
31cc41f to
c3a70e9
Compare
gartnera
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
.github/workflows/publish-release.yml (2)
51-51: Consider using a more idiomatic condition syntax.While the current condition works correctly, consider using
if: ${{ !inputs.skip_checks }}for a more idiomatic GitHub Actions syntax. This maintains the same logic while being more explicit about boolean operations.
Line range hint
186-189: Improve cleanup step error handling.The current cleanup fallback might mask real issues. Consider:
- Adding error logging
- Setting a non-zero exit code for failures
- run: sudo rm -rf * || echo "failed to cleanup workspace please investigate" + run: | + if ! sudo rm -rf *; then + echo "ERROR: Failed to cleanup workspace" >&2 + exit 1 + fi🧰 Tools
🪛 yamllint
[error] 54-54: trailing spaces
(trailing-spaces)
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (1)
.github/workflows/publish-release.yml(1 hunks)
🔇 Additional comments (3)
.github/workflows/publish-release.yml (3)
Line range hint 71-89: LGTM! Secure implementation of changelog verification.
The implementation:
- Securely uses GITHUB_TOKEN for API authentication
- Properly handles SHA comparison between develop and current branch
- Includes clear error messaging for changelog updates
🧰 Tools
🪛 yamllint
[error] 54-54: trailing spaces
(trailing-spaces)
Line range hint 108-113: LGTM! Well-implemented security controls.
The job correctly implements:
- Principle of least privilege with granular permissions
- Environment protection for release process
- Software supply chain security through build attestations
🧰 Tools
🪛 yamllint
[error] 54-54: trailing spaces
(trailing-spaces)
Line range hint 17-21: LGTM! Well-structured workflow configuration.
The workflow implements:
- Proper concurrency control to prevent parallel releases
- Clear job dependencies
- Robust release process with appropriate checks
🧰 Tools
🪛 yamllint
[error] 54-54: trailing spaces
(trailing-spaces)
check-goreleaseris a required step for doing the release. So we need to move the conditional to the step rather than the job.Summary by CodeRabbit
New Features
Bug Fixes