refactor(zetacore)!: remove rosetta api #3130
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 📝 Walkthrough📝 WalkthroughWalkthroughThe changes in this pull request involve the removal of Rosetta API support from the application, including the elimination of related commands and dependencies. Specifically, the Changes
Assessment against linked issues
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
gartnera
force-pushed
the
remove-rosetta
branch
from
117974d to
0ca7514
Compare
gartnera
requested review from
brewmaster012,
kingpinXD,
lumtis,
ws4charlie,
skosito,
swift1337 and
fbac
as code owners
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Outside diff range and nitpick comments (1)
server/start.go (1)
Line range hint
1-700: LGTM! Clean removal of Rosetta API.The changes successfully remove Rosetta API support while maintaining the integrity of the server initialization flow. The code remains well-structured with clear separation of concerns between different server components (gRPC, JSON-RPC, API server, etc.).
Consider documenting the removal of Rosetta API support in the project's changelog or migration guide, as this could be a breaking change for any external systems relying on this functionality.
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (5)
cmd/zetacored/root.go(0 hunks)docs/cli/zetacored/cli.md(0 hunks)go.mod(1 hunks)server/start.go(1 hunks)x/observer/keeper/events.go(2 hunks)
💤 Files with no reviewable changes (2)
- cmd/zetacored/root.go
- docs/cli/zetacored/cli.md
🧰 Additional context used
📓 Path-based instructions (2)
server/start.go (1)
Pattern **/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.
x/observer/keeper/events.go (1)
Pattern **/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.
🔇 Additional comments (3)
go.mod (2)
Line range hint 513-519: LGTM: Well-maintained fork replacements.
The replace directives pointing to ZetaChain maintained forks is a good practice:
- Ensures stability and control over critical dependencies
- Allows for custom patches and fixes
- Maintains compatibility with the project's requirements
Line range hint 447-451: Review new dependency versions and maintenance status.
The new dependencies added appear to be replacing removed functionality. However, we should verify their maintenance status and compatibility:
github.com/bnb-chain/tss-lib v1.5.0: Threshold Signature Scheme librarygithub.com/montanaflynn/stats v0.7.1: Statistics packagegithub.com/showa-93/go-mask v0.6.2: Data masking utilitygithub.com/tonkeeper/tongo v1.9.3: TON blockchain integrationgithub.com/zeta-chain/protocol-contracts-solana/go-idl: Solana contract integration
✅ Verification successful
Dependencies appear well-maintained with recent activity
Based on the verification results, all dependencies show healthy maintenance patterns:
- All repositories are actively maintained (not archived) and show recent activity within the last 3 months
- Notable observations:
bnb-chain/tss-lib: Latest release v2.0.2 (Jan 2024), active development with recent updatesmontanaflynn/stats: Mature project (2.9k stars), stable v0.7.1 releaseshowa-93/go-mask: Recent release v0.6.2 (July 2024)tonkeeper/tongo: Very active with updates as recent as Nov 8, 2024zeta-chain/protocol-contracts-solana: Active development with RC release in Oct 2024
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check last commit dates and open issues for new dependencies
for repo in "bnb-chain/tss-lib" "montanaflynn/stats" "showa-93/go-mask" "tonkeeper/tongo" "zeta-chain/protocol-contracts-solana"; do
echo "Checking $repo..."
gh repo view "$repo" --json updatedAt,openIssues
done
Length of output: 6995
Script:
#!/bin/bash
# Let's try a different approach to check repository activity and maintenance status
for repo in "bnb-chain/tss-lib" "montanaflynn/stats" "showa-93/go-mask" "tonkeeper/tongo" "zeta-chain/protocol-contracts-solana"; do
echo "=== Checking $repo ==="
# Get last update date and basic stats
gh repo view "$repo" --json updatedAt,pushedAt,stargazerCount,isArchived,hasIssuesEnabled
# Get latest release info if available
gh release list -R "$repo" -L 1
done
Length of output: 2748
server/start.go (1)
626-626: LGTM! Clear and helpful comment addition.
The added comment effectively explains the rationale for blocking the process in gRPC-only mode.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3130 +/- ##
===========================================
- Coverage 63.29% 63.19% -0.11%
===========================================
Files 422 423 +1
Lines 29959 29887 -72
===========================================
- Hits 18962 18886 -76
- Misses 10157 10163 +6
+ Partials 840 838 -2 |
This functionality is unused.
Cosmos sdk v0.47.x still imports it though. It should be entirely removed in v0.50.x
Closes #3109
Summary by CodeRabbit
Release Notes
New Features
zetacoredCLI, includingsnapshotsfor managing local snapshots andtestnetfor local testnet configurations.--grpc-addr,--grpc-insecure, and--heightto various commands.Bug Fixes
Documentation
Chores