fix: limit max txs in priority mempool #2547
Conversation
skosito
requested review from
brewmaster012,
kingpinXD,
lumtis,
ws4charlie,
swift1337 and
fbac
as code owners
WalkthroughWalkthroughThe recent updates introduce a new feature to the transaction processing system by implementing a cap on the maximum number of transactions in the priority mempool. This enhancement, reflected in multiple files, ensures better resource management and performance optimization by enforcing transaction limits. Additionally, a default transaction limit constant has been established, streamlining configuration for improved application robustness. Changes
Sequence Diagram(s)sequenceDiagram
participant App as Application
participant Mempool as Mempool
participant User as User
User->>App: Submit Transaction
App->>Mempool: Check transaction limit
Mempool-->>App: Limit valid
App->>Mempool: Add Transaction
Mempool-->>User: Transaction Accepted
This sequence diagram illustrates the interaction between the user, application, and mempool, emphasizing the new transaction limit check during transaction submissions. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
|
@zeta-chain/devops added as reviewer, do you guys have some stats to help on default limit? if not, just to be aware there is a flag we can configure if needed |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (3)
- changelog.md (1 hunks)
- cmd/zetacored/root.go (1 hunks)
- pkg/mempool/priority_nonce_mempool.go (1 hunks)
Additional context used
Path-based instructions (2)
cmd/zetacored/root.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.pkg/mempool/priority_nonce_mempool.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.
Additional comments not posted (3)
cmd/zetacored/root.go (1)
254-254: LGTM!The mempool is correctly set with the new priority mempool configuration.
pkg/mempool/priority_nonce_mempool.go (1)
22-22: LGTM!The constant
DefaultMaxTxsis correctly defined and integrated.changelog.md (1)
105-105: LGTM!The changelog entry is correctly formatted and accurately reflects the changes.
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (3)
- changelog.md (1 hunks)
- cmd/zetacored/root.go (1 hunks)
- pkg/mempool/priority_nonce_mempool.go (1 hunks)
Files skipped from review due to trivial changes (1)
- pkg/mempool/priority_nonce_mempool.go
Additional context used
Path-based instructions (1)
cmd/zetacored/root.go (1)
Pattern
**/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.
Additional comments not posted (2)
cmd/zetacored/root.go (1)
254-254: LGTM! Ensure the new mempool settings are tested.The code changes are approved. Ensure that the new mempool settings are thoroughly tested in various scenarios to validate the behavior.
changelog.md (1)
105-105: Entry is clear and concise.The new entry accurately describes the changes related to limiting the maximum number of transactions in the priority mempool. Ensure that the documentation is kept up to date with any further modifications.
Description
Adding a max txs to priority nonce mempool, using 3000 as default, same as cronos where this code is mostly ported from, with a possibility to configure it.
closes: #2546
How Has This Been Tested?
Summary by CodeRabbit
New Features
Bug Fixes
Documentation