Skip to content

Commit

Permalink
fixed test naming
Browse files Browse the repository at this point in the history
  • Loading branch information
kingpinXD committed Dec 20, 2024
1 parent 5171ebd commit e533f7e
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 5 deletions.
1 change: 0 additions & 1 deletion x/observer/migrations/v9/migrate.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ const MaturityBlocks = int64(100)
func MigrateStore(ctx sdk.Context, observerKeeper observerKeeper) error {
currentHeight := ctx.BlockHeight()
// Maturity blocks is a parameter in the emissions module

if currentHeight < MaturityBlocks {
return nil
}
Expand Down
4 changes: 2 additions & 2 deletions x/observer/migrations/v9/migrate_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ func TestMigrateStore(t *testing.T) {
}
})

t.Run("do not thing if ballot list for height is not found", func(t *testing.T) {
t.Run("do nothing if ballot list for height is not found", func(t *testing.T) {
//Arrange
k, ctx, _, _ := keepertest.ObserverKeeper(t)
// Set current height to 1000
Expand Down Expand Up @@ -108,7 +108,7 @@ func TestMigrateStore(t *testing.T) {
require.Equal(t, numberOfActualBlocks*numberOfBallotsPerBlock, int64(len(allBallotsAfterMigration)))
})

t.Run("do not thing if current height is less than maturity blocks", func(t *testing.T) {
t.Run("do nothing if current height is less than maturity blocks", func(t *testing.T) {
//Arrange
k, ctx, _, _ := keepertest.ObserverKeeper(t)
// Set current height to 100
Expand Down
4 changes: 2 additions & 2 deletions x/observer/types/ballot_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -488,7 +488,7 @@ func TestBallot_GenerateVoterList(t *testing.T) {
err require.ErrorAssertionFunc
}{
{
name: "Success observation",
name: "success observation",
voters: []string{"Observer1", "Observer2", "Observer3", "Observer4"},
votes: []VoteType{
VoteType_SuccessObservation,
Expand Down Expand Up @@ -518,7 +518,7 @@ func TestBallot_GenerateVoterList(t *testing.T) {
},

{
name: "Failure observation",
name: "failure observation",
voters: []string{"Observer1", "Observer2", "Observer3", "Observer4"},
votes: []VoteType{
VoteType_FailureObservation,
Expand Down

0 comments on commit e533f7e

Please sign in to comment.